GNOME Bugzilla – Bug 579370
Infinite loop trying to update file name
Last modified: 2009-05-22 18:24:55 UTC
[Debug 20:34:07.791] Updating file name for SWING HOLIC - #800080 (on VOL.02) <00:05:39.9050000> [file:///home/john/Music/SWING HOLIC/2008. VOL.02/8. #800080.ogg] [Error 20:34:07.791] Error writing to or renaming SWING HOLIC - #800080 (on VOL.02) <00:05:39.9050000> [file:///home/john/Music/SWING HOLIC/2008. VOL.02/8. #800080.ogg] [Debug 20:34:07.819] Saving metadata for SWING HOLIC - #800080 (on VOL.02) <00:05:39.9050000> [file:///home/john/Music/SWING HOLIC/2008. VOL.02/8. #800080.ogg] [Warn 20:34:07.819] Caught an exception - URI could not be converted to local file location (in `Banshee.Core') at Banshee.Base.SafeUri.UriToFilename (System.String uri) [0x00048] in /home/john/Code/3rd-party/banshee/trunk/src/Core/Banshee.Core/Banshee.Base/SafeUri.cs:105 at Banshee.Base.SafeUri.get_AbsolutePath () [0x00016] in /home/john/Code/3rd-party/banshee/trunk/src/Core/Banshee.Core/Banshee.Base/SafeUri.cs:154 at Banshee.Base.SafeUri.get_LocalPath () [0x00000] in /home/john/Code/3rd-party/banshee/trunk/src/Core/Banshee.Core/Banshee.Base/SafeUri.cs:162 at Banshee.Streaming.StreamTagger.ProcessUri (Banshee.Base.SafeUri uri) [0x00000] in /home/john/Code/3rd-party/banshee/trunk/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs:48 This message is repeated endlessly. The UI is responsive, but CPU use is pegged at 100%.
I've run into this - blocker for 1.5.0 release.
I simple way to reproduce this is to rename a file then go to Banshee and edit the corresponding track's meta-data. I will add a patch that fixes it for me, please check if it works for you as well.
Created attachment 133234 [details] [review] Fixed an infinite loop when trying to update the track metadata
Looks good, thanks Alexander. There is a second issue here ("URI could not be converted to local.."), so let's keep this open until that's fixed/investigated.
Committed
I had a bit of git confusion, and pushed my bugfix for the "could not be converted" problem to remote instead of local master. For the record, this is the patch: http://git.gnome.org/cgit/banshee/commit/?id=00e46bc7f426a03118db34b81d0840730580a818 Previously, tracks were stored with relative filenames like: 2008. VOL.02/8. #800080.ogg Part of the jobs patch apparently tried to convert these to absolute URIs, but instead of actually converting, just concatenated the filename onto the library URI. That yielded broken URIs such as those in the OP. The migration has been updated to properly convert filenames to URIs. Aaron, before I close as finished, could you confirm the patch works for you as well?
This appears to work for me. Feel free to close. Thanks John!