After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 579192 - gst_rtcp_packet_get_type should not assert on packet content
gst_rtcp_packet_get_type should not assert on packet content
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-16 18:01 UTC by Olivier Crête
Modified: 2009-04-17 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
RTCP: Don't error out on invalid packet type (928 bytes, patch)
2009-04-16 18:01 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2009-04-16 18:01:05 UTC 
gst_rtcp_packet_get_type currently asserts if the packet type field is set to 0 in a packet, it should just return it to the application (which is then free to ignore that packet).
Comment 1 Olivier Crête 2009-04-16 18:01:37 UTC 
Created attachment 132774 [details] [review]
RTCP: Don't error out on invalid packet type

It's not possible to validate the possible packet types, so let the caller decide
if the type is valid or not.
Comment 2 Olivier Crête 2009-04-16 19:47:01 UTC 
Can we get this in before 0.10.23 ?
Comment 3 Wim Taymans 2009-04-16 20:11:11 UTC 
This patch seems to make sense to include. Thaytan?
Comment 4 Jan Schmidt 2009-04-17 08:05:48 UTC 
Sure, please commit.
Comment 5 Wim Taymans 2009-04-17 09:02:10 UTC 
commit d927114ef85f41526cf749b6d3e08f5869c4c39b
Author: Olivier Crete <tester at tester.ca>
Date:   Fri Apr 17 10:53:10 2009 +0200

    RTCP: don't fail when retrieving invalid PT
    
    We can't meaningfully assert on valid packet types so just return the type as it
    is. Update the comments to reflect this.
    
    Fixes #579192.