GNOME Bugzilla – Bug 579177
GstInfo: maintain ABI compatibility
Last modified: 2009-06-12 15:24:17 UTC
This commit http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=659102e04a7111895cde506e5e3c9e118b0a81f6 removes stub functions that have been added to maintain ABI compatibility even with the debugging system in core disabled. The reason for the commit is that the no-op #defines in gstinfo.h also apply to gstinfo.c when compiling gstinfo.c, so the preprocessor will replace the function names with the no-ops, causing a build failure ... We should fix this differently though.
*** Bug 579202 has been marked as a duplicate of this bug. ***
Created attachment 132784 [details] [review] compete stubs
Author: Stefan Kost <ensonic@users.sf.net> Date: Thu Apr 16 22:26:00 2009 +0300 gstdebug: compete stubs. Fixes #579177. Avoid defines when including gstinfo.h ourself and complete stubs. Sync stub returns with the defines.
It's still breaking the ABI. At least these symbols are missing: __gst_debug_enabled __gst_debug_min _gst_debug_category_new _gst_debug_register_funcptr _gst_debug_nameof_funcptr GST_CAT_AUTOPLUG GST_CAT_AUTOPLUG_ATTEMPT GST_CAT_BUFFER GST_CAT_BUS GST_CAT_CALL_TRACE GST_CAT_CAPS GST_CAT_CLOCK GST_CAT_DEFAULT GST_CAT_ELEMENT_PADS GST_CAT_ERROR_SYSTEM GST_CAT_EVENT GST_CAT_GST_INIT GST_CAT_MESSAGE GST_CAT_NEGOTIATION GST_CAT_PADS GST_CAT_PARAMS GST_CAT_PARENTAGE GST_CAT_PIPELINE GST_CAT_PLUGIN_INFO GST_CAT_PLUGIN_LOADING GST_CAT_PROBE GST_CAT_PROPERTIES GST_CAT_QOS GST_CAT_REFCOUNTING GST_CAT_REGISTRY GST_CAT_SCHEDULING GST_CAT_SIGNAL GST_CAT_STATES GST_CAT_TYPES GST_CAT_XML
Created attachment 132999 [details] [review] Dirty(?) patch I cooked this patch quickly on Friday evening. Seems to fix it. Maybe there is a more elegant way, but AFAICS gstinfo.h is turning into #ifdef hell if you want to do it without duplicating the global variable declarations :|
I don't want to put this patch in tonight for this pre-release, but lets put it or something like it in tomorrow or Thursday, please.
On second thought, the followup patch adds symbols that were already missing in previous releases. I think it'd be better to have them so that our ABI is the same regardless of disabling debug, but since it's not a regression maybe not for this release.
I agree, but please exclude this bug from the release notes so nobody gets the impression that this is fixed.
The release script pulls in RESOLVED bugs with the target milestone set to the release number in question, so that should be fine.
Hey folks. It's been a while since the patch 132999 has been set accept-commit_after_freeze. I am a bit confused, as I don't know which freeze is to respect (anymore?). Could anybody confirm that this patch is still to commit?
Done. Good to see I'm not the only one who cares about --disable-gst-debug :) commit c403e4b7f0a66f9387893869754c90ca09de70c9 Author: René Stadler <rene.stadler@nokia.com> Date: Fri Apr 17 17:59:38 2009 +0300 Fix remaining --disable-gst-debug ABI breakage. Fixes #579177.