GNOME Bugzilla – Bug 579127
gst-launch: disable CLOCK_LOST message handling
Last modified: 2010-10-13 05:27:14 UTC
Disable the recently added handling of the CLOCK_LOST message, some elements (rtspsrc) does not seem to deal very well with the rapid PAUSED/PLAYING state change. We need to enable this when it's fixed in rtspsrc and we made a release of -good (or alternatively -bad now that gstrtpbin does not provide a clock anymore). Patch follows.
Created attachment 132743 [details] [review] Proposed patch to disable CLOCK_LOST message handling Simply comment out the code with some comments.
commit 1f8eba611a63f45766c38c640288e42b27b10bd4 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Thu Apr 16 12:01:50 2009 +0200 -launch: disable CLOCK_LOST message handling Disable the handling of the CLOCK_LOST messages until we fixed and released the elements (rtspsrc) that break when we quickly PAUSE/PLAY the pipeline. Fixes #579127
We should revert this change after 0.10.30 and make sure that good/bad is fixed.
commit be77e8d6e1205f3737df6995843901fb90b484a1 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Wed Jul 14 19:47:43 2010 +0200 Revert "-launch: disable CLOCK_LOST message handling" This reverts commit 1f8eba611a63f45766c38c640288e42b27b10bd4. This should be fixed now (and if not should be fixed) and the clock-lost handling is now needed for playbin2 gapless playback. See bug #579127.
I guess this is all good now. The only question is: do we need to implement this in apps like totem? It's another one of those barely documented things that people writing apps just have to know..
Yes, apps like totem, rhythmbox, banshee, etc have to implement this too