GNOME Bugzilla – Bug 578955
[PATCH] yelp-2.26.0 automagic lzma-utils support fixed
Last modified: 2010-05-06 21:36:35 UTC
Please describe the problem: Hi, There was lzma-utils support which is automagic in the configure script, i written a small patch to solve the problem. i just made a call to AC_ARG_ENABLE , and on user requirement, make this appropriates checks. this upstream refers to http://bugs.gentoo.org/show_bug.cgi?id=266128 bug. You'll find in attachment the patch which solves the problem. mrpouet ;) Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 132650 [details] [review] the patch which solves the problem
Hi, What problem is this solving? If LZMA is present, yelp will use it. If it isn't it won't be enabled. This is similar to the current system for bzip2 and gzip. The patch makes LZMA depend on the user defining "--enable-lzma" What advantage does this give / problem does this solve? Thanks.
Sorry I forgot to tell Romain to include this link in bug description: http://www.gentoo.org/proj/en/qa/automagic.xml Basically, automagic dependencies are a pain because it doesn't allow us to specify exact dependencies in our package manager (breaks stuff when uninstalling but a program is still using the lib and stuff like this). This is not a problem for gzip because it is part of the system set (hence always installed), and for bzip2 I guess that we didn't bother because it's too common. We can keep the automagic part for people that are happy with it but still provide configure switches to hard-enable/disable if the user really wants it. If the patch doesn't do that, feel free to mark it needswork and we will fix it. Thanks.
(In reply to comment #3) ... > > We can keep the automagic part for people that are happy with it but still > provide configure switches to hard-enable/disable if the user really wants it. > If the patch doesn't do that, feel free to mark it needswork and we will fix > it. Thanks. > I think the correct solution for this is to have a --disable-lzme switch (and an --enable-lzma switch) and keep the automagic by default (if neither are specified - does that work for packagers?). This means we won't lose functionality across releases (and no-one files bugs against loss of LZMA support). Patch has been marked as NEEDWORK. I'll also confirm the bug based on the link.
(In reply to comment #4) > I think the correct solution for this is to have a --disable-lzma switch (and > an --enable-lzma switch) and keep the automagic by default (if neither are > specified - does that work for packagers?). This means we won't lose > functionality across releases (and no-one files bugs against loss of LZMA > support). that's just fine for us. Thanks for considering.
You can now explicitly disable bz2 and lzma with configure switches. Without an explicit --disable or --enable switch, the automatic stuff still happens. Note that there's no checking for gz anymore, because it's now a hard dependency of glib.