After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578896 - Recommendations pane changes the browser height
Recommendations pane changes the browser height
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-14 02:54 UTC by Alexander Kojevnikov
Modified: 2009-04-14 23:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't change the browser height when the recommendations pane is shown (712 bytes, patch)
2009-04-14 05:13 UTC, Alexander Kojevnikov
committed Details | Review

Description Alexander Kojevnikov 2009-04-14 02:54:19 UTC
When the Last.fm recommendations are enabled, the height of the browser will reduce over time forcing the user to manually resize it.

Steps to reproduce:

1. Enable recommendations and tick off View / Browser on Top.
2. Start playing tracks.
3. When the recommendation pane pops up, notice how the height of the browser is reduced.
4. Quit and restart Banshee when this happens.
5. The height of the browser is now the same as in 3.
6. Start playng tracks again until the recommendation pane is shown.

What happens:

The height of the browser is reduced again! After a few such iterations it will be so small it would have to be resized to be usable.

What should happen:

Either the recommendation pane should not change the heigh of the browser; or Banshee should remember and restore the browser's height before it was resized by the recommendation pane.
Comment 1 Alexander Kojevnikov 2009-04-14 05:13:05 UTC
Created attachment 132625 [details] [review]
Don't change the browser height when the recommendations pane is shown
Comment 2 Bertrand Lorentz 2009-04-14 19:07:57 UTC
Good catch ! I noticed several time my browser had gotten smaller, but I never figured out why.

Looks good, please commit.
Comment 3 Alexander Kojevnikov 2009-04-14 23:03:03 UTC
Thanks Bertrand, committed!