After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578851 - build fails because -Wmissing-include-dirs isn't in gcc 3.4
build fails because -Wmissing-include-dirs isn't in gcc 3.4
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.26.x
Other opensolaris
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2009-04-13 16:58 UTC by James Andrewartha
Modified: 2009-05-15 13:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Bug 578851 – build fails because -Wmissing-include-dirs isn't in gcc 3.4 (1.40 KB, patch)
2009-04-19 14:48 UTC, Dan Winship
none Details | Review

Description James Andrewartha 2009-04-13 16:58:52 UTC
Solaris comes with gcc 3.4 which doesn't have -Wmissing-include-dirs, causing the build to fail:

 gcc -DHAVE_CONFIG_H -I. -I.. -DG_LOG_DOMAIN=\"libsoup\" -I.. -DG_DISABLE_DEPRECATED -D_REENTRANT -D_PTHREADS -I/space/buildbot/prefix/include/glib-2.0 -I/space/buildbot/prefix/lib/glib-2.0/include -DG_DISABLE_SINGLE_INCLUDES -I/space/buildbot/prefix/include/libxml2 -DORBIT2=1 -D_REENTRANT -D_PTHREADS -I/space/buildbot/prefix/include/gconf/2 -I/space/buildbot/prefix/include/orbit-2.0 -I/space/buildbot/prefix//include/dbus-1.0 -I/space/buildbot/prefix//lib/dbus-1.0/include -I/space/buildbot/prefix/include/glib-2.0 -I/space/buildbot/prefix/lib/glib-2.0/include -I/space/buildbot/prefix//include -I/space/buildbot/prefix//include -g -O2 -Wall -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wdeclaration-after-statement -Wformat=2 -Winit-self -Wmissing-include-dirs -Wundef -Waggregate-return -Wmissing-format-attribute -D_REENTRANT -MT soup-auth.lo -MD -MP -MF .deps/soup-auth.Tpo -c soup-auth.c  -fPIC -DPIC -o .libs/soup-auth.o
cc1: error: unrecognized command line option "-Wmissing-include-dirs"

-Wundef isn't in 3.4 either. http://autoconf-archive.cryp.to/ax_cflags_gcc_option.html has an autoconf macro to check, or you could adapt the one in gnome-common/macros2/gnome-compiler-flags.m4
Comment 1 Dan Winship 2009-04-19 14:48:07 UTC
Created attachment 132901 [details] [review]
Bug 578851 – build fails because -Wmissing-include-dirs isn't in gcc 3.4

Can you test that this patch works for you?
Comment 2 James Andrewartha 2009-04-20 09:53:45 UTC
Yes, this works fine. It also shows -Wundef is actually in 3.4, my mistake.
Comment 3 James Andrewartha 2009-05-15 06:58:13 UTC
Are you going to commit this?
Comment 4 Dan Winship 2009-05-15 13:50:36 UTC
oops, done. (Sorry, would have gotten to it this weekend when I deal with 2.26.2 at the latest.)