GNOME Bugzilla – Bug 578695
[patch] gimptool-2.0 does not respect $DESTDIR
Last modified: 2013-05-25 14:15:53 UTC
Please describe the problem: gimptool-2.0 does not respect $DESTDIR, and thus env DESTDIR="${D}" ${gimptool} --install-admin-bin rawphoto installs files outside ${D}. Please add the following patch from AltLinux: http://sisyphus.ru/srpm/Sisyphus/gimp/patches/0 Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 132506 [details] [review] gimp-2.6.4-alt-gimptool.patch
Actually, there is no good reason to still use gimptool as GIMP ships with a gimp.pc file a long time already. I am tempted to close this report as WONTFIX just like bug #568351. But since you attached a patch, we can consider to fix this for 2.8. The patch you provided is however not acceptable as it introduces regressions. You can't just replace get_runtime_prefix() with LIBDIR.
Can the manpage at least be fixed even if gimptool is not?
What's wrong with the manpage?
It says DESTDIR adds a prefix to the resulting path, which gimptool currently doesn't do.
Thanks. Sure, we could probably fix the manual page. But it would be much nicer if someone who cares about this issue would contribute a patch for gimptool that can be applied.
In Gentoo we've started to use pkg-config. Since gimptool is deprecated and taking into account the lack of time we have I vote to drop DESTDIR text from manpage too. And may be drop gimptool from 2.8 since it's hard to maintain two solutions for one problem, as we see here.
Fixed in master and gimp-2-8: commit aa16efe4c96d6e39be8fea4ee6443067b90cae9b Author: Michael Natterer <mitch@gimp.org> Date: Sat May 25 16:11:15 2013 +0200 Bug 578695 - gimptool-2.0 does not respect $DESTDIR Don't mention DESTDIR in the gimptool manual page. (cherry picked from commit 1a107722eaeb5586c017389a853f152506e784c0) docs/gimptool.1.in | 3 --- 1 file changed, 3 deletions(-)