GNOME Bugzilla – Bug 578656
Implement upstream GstForceKeyUnit events in theoraenc
Last modified: 2009-04-14 16:22:52 UTC
I'm attaching a series of patches that implement GstForceKeyUnit in theoraenc and update the documentation about it. The way I implemented it, the upstream event travels up the pipeline until an element that takes as input data that has no keyframes (like raw data) swallows it and re-emits it as a synchronized downstream event downstream before the next frame.
Created attachment 132489 [details] [review] theoraenc: Factor out keyframe forcing
Created attachment 132490 [details] [review] theoraenc: Implement upstream GstForceKeyUnit
Created attachment 132491 [details] [review] draft-keyframe-force: Fix typo
Created attachment 132492 [details] [review] draft-keyframe-force: Document upstream GstForceKeyUnit
Why does it need to send an event downstream as well? is there a downstream element that needs to do something special? Is it for when you have theoraenc ! oggmux and you need to also force a new 'keyframe' (page) out of the demuxer?
I just send it downstream to match the behavior is the current downstream event..
commit c628641880d9b0a1c7dacd2be8e67ecd47754d4e Author: Olivier Crete <tester at tester.ca> Date: Tue Apr 14 18:16:37 2009 +0200 theoraenc: implement upstream keyframe force Implement handling of upstream keyframe forcing. Update the design documents too. Fixes #578656 commit d0c36826278182b3bd986e6efafd65434127e26b Author: Olivier Crete <tester at tester.ca> Date: Tue Apr 14 17:31:31 2009 +0200 theoraenc: factor out keyframe forcing See #578656