After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578583 - [PATCH] multifdsink doesn't handle sync-method=latest-keyframe correctly
[PATCH] multifdsink doesn't handle sync-method=latest-keyframe correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-10 09:19 UTC by Luca Ognibene
Modified: 2009-04-12 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix check (1.06 KB, patch)
2009-04-10 09:19 UTC, Luca Ognibene 		committed Details | Review

Description Luca Ognibene 2009-04-10 09:19:15 UTC 
Try this pipeline:

GST_DEBUG=*multifd*:5 gst-launch-0.10 videotestsrc ! video/x-raw-yuv,width=160,height=120,framerate=1/1 ! ffenc_mpeg4 ! tcpserversink protocol=gdp sync-method=latest-keyframe

You'll see that tcpserversink use a queue of only 3 frames while keyframes are created every 15 frames. Patch attached.
Comment 1 Luca Ognibene 2009-04-10 09:19:42 UTC 
Created attachment 132452 [details] [review]
fix check
Comment 2 Wim Taymans 2009-04-12 20:26:40 UTC 
commit 1beabc48e865ee4da0dcd430b1cc01afaddc8dfe
Author: Luca Ognibene <luca.ognibene at gmail.com>
Date:   Sun Apr 12 22:26:33 2009 +0200

    multifdsink: fix error in sync-method
    
    Multifdsink did not handle sync-method=latest-keyframe correctly when the
    soft-limit is set to -1 (unlimited).
    Fixes #578583.