After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578467 - Should not use deprecated gtk symbols
Should not use deprecated gtk symbols
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks: 585692
 
 
Reported: 2009-04-09 10:19 UTC by Thomas Andersen
Modified: 2009-06-13 23:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Replaces deprecated gtk symbols (884 bytes, patch)
2009-04-09 10:25 UTC, Thomas Andersen 		none Details | Review
Use ifdef (1.52 KB, patch)
2009-04-23 20:14 UTC, Thomas Andersen 		none Details | Review
Bump gtk dep to 2.16 (3.43 KB, patch)
2009-04-23 21:16 UTC, Thomas Andersen 		none Details | Review

Description Thomas Andersen 2009-04-09 10:19:13 UTC 
File-roller uses the two newly deprecated gtk symbols:
gtk_widget_get_action
gtk_action_connect_proxy

These are deprecated in gtk 2.16 and should be replaced.
Comment 1 Thomas Andersen 2009-04-09 10:25:03 UTC 
Created attachment 132398 [details] [review]
Replaces deprecated gtk symbols

The patch replaces the two deprecated symbols.

The required gtk version must be bumped to 2.16 for this. From configure.ac this looks non-trivial. Would you prefer an extra GTK_2_16_REQUIRED=2.16.0 or do you plan to drop the GTK_2_12_REQUIRED stuff at some point?
Comment 2 Paolo Bacchilega 2009-04-10 08:35:05 UTC 
we can drop the gtk 2.12 compatibility source code.
Comment 3 Frederic Peters 2009-04-18 12:40:54 UTC 
Thomas, would you update your patch?

Also, instead of the current checks in configure, it could be done inline in the source files, for example:

#if GTK_CHECK_VERSION (2, 16, 0)
        action = gtk_activatable_get_related_action (GTK_ACTIVATABLE (widget));
#else                
        action = gtk_widget_get_action (GTK_WIDGET (proxy));
#endif
Comment 4 Thomas Andersen 2009-04-23 20:14:18 UTC 
Created attachment 133210 [details] [review]
Use ifdef

This patch uses #if GTK_CHECK_VERSION (2, 16, 0) as mentioned.
Comment 5 Thomas Andersen 2009-04-23 21:16:17 UTC 
Created attachment 133220 [details] [review]
Bump gtk dep to 2.16

Gtk dep is bumped to 2.16 for gtk_activatable_get_related_action.
configure.ac: Simplified to drop the gtk 2.12 compatibility as per comment in the bug.
stc/gtk-utils.c: Removed checks for gtk < 2.13 due to new dep on 2.16.

Note that there is still code left with GTK_CHECK_VERSION (2, 12, 0) in copy-n-paste/eggdesktopfile.c
Comment 6 Thomas Andersen 2009-04-29 23:20:01 UTC 
could this get in before 2.27.1?
Comment 7 Paolo Bacchilega 2009-04-30 09:19:31 UTC 
patch applied, thank you.