After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578463 - Should not use deprecated gtk_status_icon_set_tooltip
Should not use deprecated gtk_status_icon_set_tooltip
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks: 585692
 
 
Reported: 2009-04-09 09:20 UTC by Thomas Andersen
Modified: 2009-06-13 23:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Replaces gtk_status_icon_set_tooltip (857 bytes, patch)
2009-04-09 09:21 UTC, Thomas Andersen
none Details | Review
Replaces gtk_status_icon_set_tooltip (1.37 KB, patch)
2009-04-26 22:34 UTC, Thomas Andersen
committed Details | Review

Description Thomas Andersen 2009-04-09 09:20:09 UTC
Vino server is using the deprecated gtk_status_icon_set_tooltip. The function was deprecated in gtk 2.16 and should be replaced by gtk_status_icon_set_tooltip_text. This is only deprecated gtk symbol in use in vino.
Comment 1 Thomas Andersen 2009-04-09 09:21:26 UTC
Created attachment 132393 [details] [review]
Replaces gtk_status_icon_set_tooltip

replaces gtk_status_icon_set_tooltip with gtk_status_icon_set_tooltip_text. Also bumps gtk requirement to 2.16 in configure.in
Comment 2 Frederic Peters 2009-04-18 12:46:14 UTC
Jonh, would you branch so this could this go in? Thanks.
Comment 3 Jonh Wendell 2009-04-21 13:32:07 UTC
Will do this next week, when I'll have Ubuntu Jaunty on my system (gtk+ 2.16)
Comment 4 Thomas Andersen 2009-04-26 22:34:48 UTC
Created attachment 133372 [details] [review]
Replaces gtk_status_icon_set_tooltip

Same patch but created with git format-patch HEAD^ for convenience
Comment 5 Thomas Andersen 2009-04-29 23:18:10 UTC
could this get in before 2.27.1?
Comment 6 André Klapper 2009-05-02 03:10:02 UTC
Jonh: Got Jaunty? :-)
Comment 7 Jonh Wendell 2009-05-02 12:44:52 UTC
Patch committed, thanks.

BTW, I'm not planning to release a 2.27.1 version, there aren't any valuable changes...
Comment 8 André Klapper 2009-05-02 15:31:20 UTC
Sure, np. Just happy that this is in.