GNOME Bugzilla – Bug 578393
convert from libglade to GtkBuilder
Last modified: 2009-08-06 14:39:16 UTC
As you probably know libglade is deprecated and its use should be replaced with GtkBuilder. Unfortunately zenity is a libglade-user and thus should be converted.
Created attachment 132347 [details] [review] Conversion to GtkBuilder This simply replaces libglade calls with their matching GtkBuilder counterparts without doing much optimization (patch is big enough already). Most dialogs seem to work like they should. Can't say about the List/Tree dialog as I don't really understand how it works from the commandline. UI file is made with Glade 3.6.
*ping* :-) Would be one "average offender" less on the big list of things to do until 3.0. ;-)
Looks good! Please commit.
It's in. Thanks for reviewing. :-) commit 3f33966167cf2216f813c091d47461c451837602 Author: Felix Riemann <> Date: Mon Jul 20 10:23:32 2009 +0200 Bug 578393 – convert from libglade to GtkBuilder configure.in | 2 +- po/POTFILES.in | 2 +- po/POTFILES.skip | 1 + src/Makefile.am | 8 +- src/calendar.c | 23 +- src/entry.c | 24 +- src/fileselection.c | 1 - src/msg.c | 48 +- src/notification.c | 1 - src/progress.c | 41 +- src/scale.c | 29 +- src/text.c | 19 +- src/tree.c | 34 +- src/util.c | 60 ++- src/util.h | 8 +- src/zenity.ui | 1854 +++++++++++++++++++++++++++++++++++++++++++++++++++ 16 files changed, 2019 insertions(+), 136 deletions(-) This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Created attachment 138786 [details] [review] Clean some libglade references I've reopen but there are some libglade references in the module
(In reply to comment #5) > Created an attachment (id=138786) [edit] > Clean some libglade references > > I've reopen but there are some libglade references in the module > Heh, I haven't looked into the README. :-) If you delete the glade file you need to remove its line from po/POTFILES.skip also. I kept it, because when I made the patch back in April I was a bit unsure about glade3's GtkBuilder support. Regarding the spec file. Well, it hasn't been updated since 2003 and at least the listed dependencies are insufficient. As most RPM-using distros likely have their own spec files for Zenity, this could probably removed as well.
Created attachment 138811 [details] [review] Clean some things in GtkBuilder port v2 I've created a new .ui file with the latest version of Glade 3.6.7 Seems to work well. Regards
(In reply to comment #7) > Created an attachment (id=138811) [edit] > Clean some things in GtkBuilder port v2 > > I've created a new .ui file with the latest version of Glade 3.6.7 > Seems to work well. > Just noticed that this fixes a commit error I made. I apparently committed the UI file containing its content twice. :(
Pushed to master, thanks!