GNOME Bugzilla – Bug 578336
ABI breakage from 1.22 to 1.24 in fontmap field of PangoFcFont
Last modified: 2009-04-08 19:51:29 UTC
Hi, there seems to be ABI breakage from 1.22 to 1.24 in fontmap field of PangoFcFont. Previously setting the fontmap field lead to an assertion, nowadays it is expected to be set from PangoFcFont subclasses and will lead to crashes otherwise. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=522675 for a more detailed description
The severity of the issue is grossly overstated. The change only affects code implementing its own PangoFcFont subclass. The only such code known to me so far is gecko. I failed to find in the report which other project is affected. Anyway, I committed a patch that should fix the issue. Please have them test and report. [pangofc] Be more tolerant on the "fontmap" property setting Bug 578336 – ABI breakage from 1.22 to 1.24 in fontmap field of PangoFcFont Commit 9305b9a9995e84ace3818a90346820ef8c47a3ce introduced a "fontmap" property in PangoFcFont and expected all subclasses to set it upon construction. And PangoFcFontSet was changed to not set fcfont->fontmap anymore. Relax this change to make it backward compatible by: 1) Making "fontmap" property a not-construct-only property 2) In PangoFcFontSet, set "fontmap" if not already set This should make it backward compatible, while allowing new code to set the property instead of relying on PangoFcFontSet to do it.