GNOME Bugzilla – Bug 578303
Fix highliting in the last line of text
Last modified: 2009-04-20 20:14:45 UTC
This patch fixes the highlighting of changes that end in the last line.
Created attachment 132298 [details] [review] Patch to fix highlighting
Created attachment 132391 [details] [review] Wrong patch - see next attachment instead Another patch to fix the way end of file is handled. This time there was a bug in Differ that changed sequence length twice when the text in middle pane was modified.
Comment on attachment 132391 [details] [review] Wrong patch - see next attachment instead
Comment on attachment 132391 [details] [review] Wrong patch - see next attachment instead Index: diffutil.py =================================================================== --- diffutil.py (revision 1329) +++ diffutil.py (working copy) @@ -76,6 +76,7 @@ else: # sequence==1: changes[0] = self._change_sequence( 0, sequence, startidx, sizechange, texts) if self.num_sequences == 3: + self.seqlength[sequence] -= sizechange changes[1] = self._change_sequence( 1, sequence, startidx, sizechange, texts) return changes
Created attachment 132392 [details] [review] Patch to fix change_sequence Change change_sequence so that size change is not applied twice for the middle pane.
Created attachment 132682 [details] [review] Fix change_sequence() not to change sequence size twice
https://bugs.launchpad.net/ubuntu/+source/meld/+bug/89000 should be fixed by http://bugzilla.gnome.org/attachment.cgi?id=132682 as should http://bugzilla.gnome.org/show_bug.cgi?id=342633 Really nice {c,p}atch !
probably http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465804 too
and http://bugzilla.gnome.org/show_bug.cgi?id=484177
Thanks Piotr, thats great to have two long standing bugs solved.
Where are those patches committed, I can't see them...
Take a look at git repository :)
WHAT ?!? There's a git repository ? Where is that, I can't see it advertised on meld.sf.net web site, nor anywhere else... I found it: http://git.gnome.org/cgit/meld Argh, I was maintaning a huge pile of patches against svn trunk when I could have done it with git... :-\ Thanks for the hint BTW...