After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578201 - _gst_plugin_fault_handler_is_setup undefined under HAVE_WIN32
_gst_plugin_fault_handler_is_setup undefined under HAVE_WIN32
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.22
Other Cygwin
: Normal blocker
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-07 06:13 UTC by cyanbeck
Modified: 2009-04-17 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix: move variable into the block where it's used (1.16 KB, patch)
2009-04-16 23:15 UTC, Tim-Philipp Müller 		committed Details | Review

Description cyanbeck 2009-04-07 06:13:30 UTC 
If HAVE_WIN32 is defined, _gst_plugin_fault_handler_is_setup will not be defined. However, functions below (_gst_plugin_fault_handler_restore and _gst_plugin_fault_handler_setup) use this variable whether HAVE_WIN32 is defined or not.
Comment 1 Tim-Philipp Müller 2009-04-16 23:15:35 UTC 
Created attachment 132800 [details] [review]
proposed fix: move variable into the block where it's used
Comment 2 Tim-Philipp Müller 2009-04-16 23:16:25 UTC 
Jan, maybe this could go in as well?
Comment 3 Tim-Philipp Müller 2009-04-17 08:24:23 UTC 
commit b31896b2af77271ec6d7214280240aba97c1e65a
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Apr 17 09:17:40 2009 +0100

    GstPlugin: fix compilation if both HAVE_WIN32 and HAVE_SIGACTION are defined
    
    Move _gst_plugin_fault_handler_is_setup into the ifdef block where it's
    used. Fixes #578201.