After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578166 - libgstwaveform, gstwaveformsink.c "BYTE" instead of "byte"
libgstwaveform, gstwaveformsink.c "BYTE" instead of "byte"
Status: RESOLVED DUPLICATE of bug 585361
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.22
Other Windows
: Normal enhancement
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-06 19:08 UTC by David Hoyt
Modified: 2009-08-09 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible fix (622 bytes, patch)
2009-04-06 19:09 UTC, David Hoyt 		none Details | Review

Description David Hoyt 2009-04-06 19:08:56 UTC 
Line 503 of gstwaveformsink.c (data = (byte *) data + bytes_to_write;) may want to use "BYTE" instead of "byte".
Comment 1 David Hoyt 2009-04-06 19:09:30 UTC 
Created attachment 132212 [details] [review]
Possible fix
Comment 2 Sebastian Dröge (slomo) 2009-08-09 10:55:44 UTC 
This is obsolete now:

commit 2e13b85a016330729a3c6ac39d006d06fc1db996
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Jun 25 18:51:12 2009 +0100

    waveformsink: use 'guint8' instead of 'byte' to fix compilation with MSVC8
    
    We need a cast here for pointer arithmetic to work correctly, but some
    MSVC versions don't seem to like 'byte', so use guint8 here. Hopefully
    fixes #585361.


*** This bug has been marked as a duplicate of 585361 ***