After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578135 - [qtdemux] missing 3gpp Asset metadata handling
[qtdemux] missing 3gpp Asset metadata handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-06 14:21 UTC by Marco Ballesio
Modified: 2009-04-15 17:16 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
proposed patch for handling 3gpp Asset metadata with qtdemux (10.00 KB, patch)
2009-04-06 14:44 UTC, Marco Ballesio 		committed Details | Review
Adjust patch (2.70 KB, patch)
2009-04-14 15:10 UTC, Mark Nauwelaerts 		committed Details | Review

Description Marco Ballesio 2009-04-06 14:21:14 UTC 
qtdemux is currently not handling metadata as specified in 3GPP-TS-26.244-V8.0.0, Asset metadata handling. This is particularly problematic when handling 3gp files recorded with cellphones.
Comment 1 Marco Ballesio 2009-04-06 14:44:47 UTC 
Created attachment 132193 [details] [review]
proposed patch for handling 3gpp Asset metadata with qtdemux
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-04-14 13:42:36 UTC 
This needs some work. The location fields are fixed floating point format and need to be divided by 65536.0
Comment 3 Mark Nauwelaerts 2009-04-14 15:10:51 UTC 
Created attachment 132643 [details] [review]
Adjust patch

This (incremental) patch should handle the aforementioned fixed-point issue, as well as using some more convenient and traditional GLib calls.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2009-04-15 17:16:29 UTC 
Committed with small changes. There was another off by one, now the location tags are fine. And I added two more comments. Mark, thanks for your patch too.

commit 94d5d24cf0e72752d6d7d10c8357e48eaf366ca2
Author: Marco Ballesio <marco.ballesio@nokia.com>
Date:   Wed Apr 15 20:10:04 2009 +0300

    qtdemux: implement 3GPP (TS 26.244 V8.0.0) Asset metadata handling, Fixes #132193
    
    Implements 3gpp iso metadata tags which are different from mov udta atoms.