GNOME Bugzilla – Bug 578073
ID3 release date (TDRC) tag missing when importing a CD (to MP3)
Last modified: 2009-04-15 22:05:22 UTC
Please describe the problem: When importing a CD to MP3, the release date ID3 tag is missing from the MP3s though Musicbrainz has the metadata Steps to reproduce: 1. import a CD (rip to MP3) where Musicbrainz knows the release date 2. look at ID3v2 tags of MP3s created Actual results: "release date" tag missing from MP3 Expected results: "release date" tag should exist (at least the year) Does this happen every time? Other information:
The reason is that Musicbrainz metadata XML supplies the date as "YYYY-MM-DD", "YYYY-MM" or "YYYY", but it is parsed (in src/Extensions/Banshee.AudioCd/Banshee.AudioCd/AudioCdDiscModel.cs, method LoadDiscMetadata) as DateTime.Parse (release_event.Date, ApplicationContext.InternalCultureInfo) I know of no culture that would use the above format :), hence this always throws a parse exception (that is ignored), album.ReleaseDate is set to DateTime.MinValue and hence ignored for tagging.
Created attachment 132153 [details] [review] parse release_event.Date as specified in Musicbrainz metadat XML schema patch against SVN r5186
Thanks Roderich. In my testing, "YYYY-MM-DD" and "YYYY-M(M)" parse just fine, but "YYYY" doesn't, so I committed a patch that handles that case.