After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 578073 - ID3 release date (TDRC) tag missing when importing a CD (to MP3)
ID3 release date (TDRC) tag missing when importing a CD (to MP3)
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
git master
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-05 21:23 UTC by Roderich Schupp
Modified: 2009-04-15 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
parse release_event.Date as specified in Musicbrainz metadat XML schema (1.89 KB, patch)
2009-04-05 21:28 UTC, Roderich Schupp
none Details | Review

Description Roderich Schupp 2009-04-05 21:23:16 UTC
Please describe the problem:
When importing a CD to MP3, the release date ID3 tag is missing
from the MP3s though Musicbrainz has the metadata

Steps to reproduce:
1. import a CD (rip to MP3) where Musicbrainz knows the release date
2. look at ID3v2 tags of MP3s created



Actual results:
"release date" tag missing from MP3

Expected results:
"release date" tag should exist (at least the year)

Does this happen every time?


Other information:
Comment 1 Roderich Schupp 2009-04-05 21:25:40 UTC
The reason is that Musicbrainz metadata XML supplies the date
as "YYYY-MM-DD", "YYYY-MM" or "YYYY", but it is parsed 
(in src/Extensions/Banshee.AudioCd/Banshee.AudioCd/AudioCdDiscModel.cs,
method LoadDiscMetadata) as

DateTime.Parse (release_event.Date, ApplicationContext.InternalCultureInfo)

I know of no culture that would use the above format :), hence this always
throws a parse exception (that is ignored), album.ReleaseDate is set to
DateTime.MinValue and hence ignored for tagging.
Comment 2 Roderich Schupp 2009-04-05 21:28:27 UTC
Created attachment 132153 [details] [review]
parse release_event.Date as specified in Musicbrainz metadat XML schema

patch against SVN r5186
Comment 3 Gabriel Burt 2009-04-15 22:05:22 UTC
Thanks Roderich.  In my testing, "YYYY-MM-DD" and "YYYY-M(M)" parse just fine, but "YYYY" doesn't, so I committed a patch that handles that case.