After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577855 - Disable gdmuser debugging messages
Disable gdmuser debugging messages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-04-03 15:01 UTC by Dan Winship
Modified: 2009-04-03 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable gdmuser debugging messages (unless GNOME_SHELL_DEBUG is set) (1.38 KB, patch)
2009-04-03 15:01 UTC, Dan Winship 		none Details | Review
Disable gdmuser debugging messages (unless "gdm" is set in GNOME_SHELL_DEBUG) (1.64 KB, patch)
2009-04-03 15:46 UTC, Dan Winship 		reviewed Details | Review

Description Dan Winship 2009-04-03 15:01:47 UTC 
This gets rid of the gdmuser debugging messages that aren't generally
interesting to us, to help make actual interesting messages more noticeable.

I wasn't sure if the gdmuser/ code was a clean import from gdm. If so, we
could move this code somewhere else (shell-status-menu?).
Comment 1 Dan Winship 2009-04-03 15:01:51 UTC 
Created attachment 132007 [details] [review]
Disable gdmuser debugging messages (unless GNOME_SHELL_DEBUG is set)
Comment 2 Owen Taylor 2009-04-03 15:32:45 UTC 
Would it make sense and just dive in and use g_parse_debug_string(), I have a certain prejudice against having empty envvars enable something.
Comment 3 Dan Winship 2009-04-03 15:46:31 UTC 
Created attachment 132011 [details] [review]
Disable gdmuser debugging messages (unless "gdm" is set in GNOME_SHELL_DEBUG)

This uses g_parse_debug_string(), though it still uses it from within
gdm-user-manager.c, rather than doing it in a central location with lots of
other debug keys too and then passing the flag to gdm-user-manager
somehow. But we can still have other code calling g_parse_debug_string() too.
Comment 4 Colin Walters 2009-04-03 17:43:50 UTC 
Sounds good to me.
Comment 5 Owen Taylor 2009-04-03 17:47:42 UTC 
The local parse of GNOME_SHELL_DEBUG seems like it will work - the only thing that breaks is GNOME_SHELL_DEBUG=help, and who uses that... looks good to me.
Comment 6 Dan Winship 2009-04-03 18:35:08 UTC 
committed