After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577690 - rtpdtmfmux: missing pad unref
rtpdtmfmux: missing pad unref
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-02 09:00 UTC by Laurent Glayal
Modified: 2009-04-15 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Laurent Glayal 2009-04-02 09:00:00 UTC 
Unref pad on finalize if necessary.

diff --git a/gst/rtpmux/gstrtpdtmfmux.c b/gst/rtpmux/gstrtpdtmfmux.c
index f98d7a0..0ac8335 100644
--- a/gst/rtpmux/gstrtpdtmfmux.c
+++ b/gst/rtpmux/gstrtpdtmfmux.c
@@ -163,6 +163,12 @@ gst_rtp_dtmf_mux_finalize (GObject * object)

   mux = GST_RTP_DTMF_MUX (object);

+  if ( mux->special_pad != NULL )
+    {
+      gst_object_unref (mux->special_pad);
+      mux->special_pad = NULL;
+    }
+
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }
Comment 1 Olivier Crête 2009-04-15 17:23:22 UTC 
commit 65cb85316bec86391fd235adf15716f44230e646
Author: Laurent Glayal <spglegle@yahoo.fr>
Date:   Wed Apr 15 13:09:27 2009 -0400

    rtpdtmfmux: Release special on pad dispose
    
    Fixes #577690