After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577609 - [id3v2mux] write RVA2 frames for peak/gain volume data
[id3v2mux] write RVA2 frames for peak/gain volume data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-04-01 12:53 UTC by Jonathan Matthew
Modified: 2009-04-01 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add relative volume frame output (7.00 KB, patch)
2009-04-01 13:00 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2009-04-01 12:53:46 UTC 
id3v2mux currently doesn't write RVA2 (relative volume) frames to store the replaygain tags it receives.
Comment 1 Jonathan Matthew 2009-04-01 13:00:12 UTC 
Created attachment 131839 [details] [review]
add relative volume frame output

The interesting bits here are:
- there can only be one frame of each type (track or album), so we check for both tags, and if both are present, only write the frame when processing the peak tag
- rather than doing anything clever to store the peak value, I just copied mutagen's approach of always converting the value to 16 bits
- the comparison in the unit test checks that the value extracted from the tag is within 2% of the original, since the values aren't stored with much precision
Comment 2 Tim-Philipp Müller 2009-04-01 23:23:07 UTC 
Cool, thanks!

commit 9b7c9208c3e4fac08c405e39c23577de943140d0
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Thu Apr 2 00:20:02 2009 +0100

    id3v2mux: write RVA2 frames containing peak/gain volume data