After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577130 - Incorrect title in GalleryExport (please revert patch from 543863)
Incorrect title in GalleryExport (please revert patch from 543863)
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: Metadata
0.5.x
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-28 21:47 UTC by Rob Lanphier
Modified: 2009-08-20 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to revert filename as title patch (2.19 KB, patch)
2009-05-04 06:59 UTC, Rob Lanphier
rejected Details | Review

Description Rob Lanphier 2009-03-28 21:47:09 UTC
Please describe the problem:
The patch in issue 543863 introduced a different field mapping from F-Spot photos to the exported Gallery version.  The old way of handling things was that the Gallery "title" field was set to the F-Spot "comment" field, and the Gallery filename was set to the F-Spot filename.  

Steps to reproduce:
1.  Set a comment on a photo in F-Spot
2.  Export the photo to Gallery 2.3
3.  View the photo in Gallery

Actual results:
The filename shows as the title in Gallery

Expected results:
The comment should show as the title in Gallery

Does this happen every time?
Yes

Other information:
View the difference in behavior at http://photos.robla.net/gallery/v/2009/hidden/fspot543863
Comment 1 Rob Lanphier 2009-03-28 21:49:21 UTC
I should have said bug 543863 instead of issue 543863
Comment 2 Pascal de Bruijn 2009-03-29 10:16:12 UTC
The comments field should never be used as a title... For the simple following reason.

If GalleryExport were to export the comment as title, it would restrict anybody using the comments field to only use a few words as comment.

For example I have a photo with the comments:
"This is michelle posing for event blah, on blah... and so on"

Which is a proper comment/description, but this would look odd as a title. Since it's much too long.

The proper fix would be have a seperate title field in F-Spot. Using the description/comment as title is a very poor workaround which forces people to limit their use of the description/comment field as it's intended.
Comment 3 Rob Lanphier 2009-03-29 16:52:03 UTC
Hmmm....the comment field is a single line text entry.  While that doesn't limit it to a single line, saying that "the comment field should never be used as a title" is way too strong a statement.  F-Spot has been using the comment field as a title for at least a couple of years, and my family has been pretty heavy users of this feature (see http://photos.robla.net ).

The "title" field in Gallery is clearly meant as a freeform text field, and the most prominent piece of text associated with a photo.  F-Spot is pretty clearly designed to not have end users futzing with filenames, so making the filename as the title forces the end user to use some outside program to manage the photos, which I hope is not the intent of the F-Spot dev team.

There's really no way to make everyone happy, other than maybe a configurable option (which would still upset the people who want to keep the UI simple).  
Comment 4 Rob Lanphier 2009-04-13 06:40:20 UTC
Looks like I may have had the permissions screwed up on the URL in the description (http://photos.robla.net/gallery/v/2009/hidden/fspot543863
 ).  I think it's fixed now...let me know if you have trouble viewing it.
Comment 5 Rob Lanphier 2009-05-04 06:59:38 UTC
Created attachment 133903 [details] [review]
patch to revert filename as title patch

Attaching a patch to revert this feature.  Tested on 0.5.0.3 (Ubuntu Jaunty)
Comment 6 Stephane Delcroix 2009-08-20 15:26:53 UTC
as pascal said, this is not a bug. as the gallery stuff is an extension, feel free to build your own one, with whatever behavior you like, but we'd prefer keeping it as is as official one for now.