GNOME Bugzilla – Bug 577079
Specific tab for Diff
Last modified: 2010-06-06 22:16:10 UTC
I feel that it will be better to have a dedicated tab for the diff in the History view. First, this will reduce the size of the main window. Then, this will allow to add more data in the "Details" tab (for example, parents and children commits, full log, author+commiter...) PS: I reanime an old issue because I'm not sure to be really easy to understand the first time. Please, read last comments.
Jesse initially replied: I think this is a bad idea. I think the history and diff are very useful to have next to each other so you can easily browse your history and see the changes. I myself am never really interested in things like parents and children because you can see those quite obviously in the tree already. I'm closing this as a 'wontfix' for now.
We definitively have different opinion on this idea. Personnaly, I regularly need to browse the history with *parents* and *children* links. In fact, I have long living branches, with few activities, mixed with really active branches. So history graph is not the best way to navigate.
I recently worked on this feature. I created a branch: http://github.com/guyou/gitg/tree/tab-for-changes I also posted some screenshot of my current work (screeny is better than long "discours"): http://picasaweb.google.fr/guilhem.bonnefille/CapturesDCran?feat=directlink#5318257023346977026 Due to space gained, we are able to display full log message on "Details" tab http://picasaweb.google.fr/guilhem.bonnefille/CapturesDCran?feat=directlink#5318257018887073106 Any comments welcome.
Created attachment 131699 [details] [review] Current state of diff I add a patch file in order to keep track of the availability of a patch (waiting for a "pull request" property in Gnome's bugzilla).
I improved my patch. The "Details" tab displays: - the author and committer - both are clickable: a click open your mail agent to send a mail - the first line of the log message (the title) is rendered bold - the Signed-off-by line are rendered specifically - the email associated to the Signed-off-by keyword is clickable Give an eye: http://picasaweb.google.fr/lh/photo/gFJCtDPu7621FSFJYylNnw?feat=directlink The code is hosted on my tab-for-changes topic branch: http://github.com/guyou/gitg/tree/tab-for-changes
Another solution would be to have only the diff view (and not the file list) in the main tab, and scroll it along with the info, i.e. have a single ScrollWindow which contained both the info and the diff. A diff (or "changes") tab could present an expanded diff view with the file list and everything. Most commits I make affect only a few files, and a flat view is more than enough for that.
I've separated the functionality (details, changes, files) in separate panels now. Also added more info to the details panel, and added stats (i.e. --stat). The implementation is a bit different, so I took inspiration from your patch (many thanks again!)!.