GNOME Bugzilla – Bug 576879
Ctrl+L does not show layers in Integrated UI
Last modified: 2010-07-16 11:42:54 UTC
Reported by Slavko on the mailing list: when I swap to integrated interface, I can't show Layers Window (Ctrl+L). Nor by menu "Layers -> Layers", nor by hot key. Only by menu "Show -> Layers". Is it really a good idea to have two menu entries for the same thing?
IMO it is not the same thing, so the bug is the Layers/Layers... menu entry. Or maybe even the whole (almost unmaintained) integrated UI.
The Layer menu was added to the integrated UI on March 7th without being tested.
Give me more of this hints and I'll just remove the integrated UI code ;) I already fixed a bunch of bugs in the original integrated UI code, but given that I'm not using it myself and it just adds a further dimension in complexity I don't see how it could be maintained without a volunteer. Would it help if I CC you on every integrated UI bug? Do you want to review patches (e.g. I already have one for bug #573635)
Yes, CC me on integrated UI bugs. I have not contributed in a while because I am not using Dia and I haven't gotten feedback.
So far, I've got feedback from ~20 Dia for Windows users regarding the Integrated UI. 100% were in favour of the Integrated UI.
Interesting, but what's the proposal for the issue at hand? - remove the menu entry and bind Ctrl-L to "ViewLayers" - redo the whole Layers menu for iUI - make Layers/Layers... open the dialog even for iUI - map Layers/Layers... ("DiagramLayers") to "ViewLayers" for iUI - something completely different
I am in favor of this: -remove the menu entry and bind Ctrl-L to "ViewLayers" But I don't use Layers. I never had a strong opinion on how this should work in the integrated UI. Lars (I think) requested some kind of non-dialog behavior.
Should I go ahead and remove the layer menu and create the key binding?
do you want to remove the whoe layer menu from the iUI menu? Or just the Layers entry? (Both would be fine with me but the former would also remove some new functions completely from the iUI). I hestitate to add further if(iUI) code into Dia, though. The special code pathes for this mode should be reduced, not extended.
I was thinking of just removing the layers menu but I'm open to removing the offending item. My inclination, though, is to make it work as expected. I haven't looked yet but it can't be much work. I agree that my code needs to be cleaned up. It felt hack-ish when I was making my changes. Like a proof of concept.
2009-04-13 Hans Breuer <hans@breuer.org> * data/integrated-ui.xml app/menus.c : removed Layers/Layers... from the integrated UI menu and assigned <control>L also to ShowLayers (the two menu entries are never available together, so no conflict) Fixes bug #576879. * app/preferences.[ch] :removed "Integrated UI" option here ... (together with the annoying change-needs-restart message) * app/app_procs.c : ... and made it a start-up option, aka. command line switch. If the UI type some day can be switch at runtime the prefernce setting may be added again.
*** Bug 624533 has been marked as a duplicate of this bug. ***