After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576842 - loading a broken registry file can crash
loading a broken registry file can crash
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-26 11:07 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-03-27 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for not reading beyond the data area (16.23 KB, patch)
2009-03-26 11:11 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-26 11:07:29 UTC 
The whole binrary registry reading code is not testing for reading beyond the data region. E.g. we are using an unbound strlen. Also in case of failure partialy read object are not rolled back. Thus they are not rescanned when rereadign the registry and feature will be missing.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-26 11:11:14 UTC 
Created attachment 131426 [details] [review]
check for not reading beyond the data area
Comment 2 Tim-Philipp Müller 2009-03-26 16:19:45 UTC 
Making things a bit more robust is not a bad idea, I guess, even if we should never actually run into this problem in practice.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-27 15:11:45 UTC 
Lets give it a try then :)