After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576684 - implement pixel sized font units in gtk_html_set_fonts and html_painter_alloc_font
implement pixel sized font units in gtk_html_set_fonts and html_painter_alloc...
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Rendering
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
Depends on:
Blocks: 576694
 
 
Reported: 2009-03-25 09:54 UTC by Alexander Sack
Modified: 2009-06-15 05:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
implements "points" (809 bytes, patch)
2009-03-25 09:57 UTC, Alexander Sack
none Details | Review
right patch (3.32 KB, patch)
2009-03-25 10:01 UTC, Alexander Sack
committed Details | Review

Description Alexander Sack 2009-03-25 09:54:52 UTC
Currently there seems to be a boolean parameter "points" that indicates whether a font is point or pixel sized. However, this seems not to be used properly. I assume its supposed to indicate whether a font is point sized or not.

Attaching patch.
Comment 1 Alexander Sack 2009-03-25 09:57:52 UTC
Created attachment 131329 [details] [review]
implements "points"

i also changed the testcase to use absolute font sizing... thats obviously not a required piece, but i thought i should include it.
Comment 2 Alexander Sack 2009-03-25 10:01:26 UTC
Created attachment 131330 [details] [review]
right patch
Comment 3 Alexander Sack 2009-03-25 10:02:40 UTC
see ubuntu bug: https://bugs.edge.launchpad.net/bugs/345189
Comment 4 Matthew Barnes 2009-04-07 12:19:13 UTC
You had a similar patch for ETable, didn't you?  I must have missed this one.

This looks fine as well.  Approved.
Comment 5 Alexander Sack 2009-06-09 14:21:39 UTC
can you please commit? i didn't come to applying for an account yet ;). Thanks!
Comment 6 Bharath Acharya 2009-06-15 05:37:16 UTC
This was committed long back by Tobias Mueller

http://git.gnome.org/cgit/gtkhtml/commit/?id=2598838b576710a6f9c3bb75e58d97f6522d1cf5

Closing