GNOME Bugzilla – Bug 576496
gnome-keyring does not pass its testsuite
Last modified: 2009-09-13 22:46:14 UTC
Attaching log in a moment.
Created attachment 131222 [details] build.log.gz
Hmmm, that's very odd. It seems that somehow the run-auto-tests.h file in that directory isn't being generated properly. Could you attach it? Thanks!
I get this bug again while bumping to 2.26.3 today, plus I have also experienced our of our user bug as well [1]. I think those issues are similar and due to parallel make failures. I'll try to see what this is later. [1] https://bugs.gentoo.org/show_bug.cgi?id=272450
*** Bug 595104 has been marked as a duplicate of this bug. ***
Created attachment 143119 [details] [review] Patch to fix the issue Okay this is the fix for the current git master; the problem was a race condition in the make fragment, as well as missing BUILT_SOURCES usage for automake. HTH, Diego
re-opening since information and patch have been provided.
Thanks for taking the time to figure that out Diego. Sadly the patch breaks the build for me. I believe that the BUILT_SOURCES causes both run-prompt-test.c and run-auto-test.c to be linked into the same executable. I'll put this back in your hands. Looking forward to a tweaked patch. automake: 1.11 autoconf: 2.64 make all-recursive make[1]: Entering directory `/data/projects/gnome-keyring' Making all in . make[2]: Entering directory `/data/projects/gnome-keyring' make[2]: Leaving directory `/data/projects/gnome-keyring' Making all in gp11 make[2]: Entering directory `/data/projects/gnome-keyring/gp11' make all-recursive make[3]: Entering directory `/data/projects/gnome-keyring/gp11' Making all in . make[4]: Entering directory `/data/projects/gnome-keyring/gp11' make[4]: Nothing to be done for `all-am'. make[4]: Leaving directory `/data/projects/gnome-keyring/gp11' Making all in tests make[4]: Entering directory `/data/projects/gnome-keyring/gp11/tests' make all-am make[5]: Entering directory `/data/projects/gnome-keyring/gp11/tests' make[5]: Nothing to be done for `all-am'. make[5]: Leaving directory `/data/projects/gnome-keyring/gp11/tests' make[4]: Leaving directory `/data/projects/gnome-keyring/gp11/tests' make[3]: Leaving directory `/data/projects/gnome-keyring/gp11' make[2]: Leaving directory `/data/projects/gnome-keyring/gp11' Making all in egg make[2]: Entering directory `/data/projects/gnome-keyring/egg' make all-recursive make[3]: Entering directory `/data/projects/gnome-keyring/egg' Making all in . make[4]: Entering directory `/data/projects/gnome-keyring/egg' make[4]: Nothing to be done for `all-am'. make[4]: Leaving directory `/data/projects/gnome-keyring/egg' Making all in tests make[4]: Entering directory `/data/projects/gnome-keyring/egg/tests' make[4]: Circular run-auto-test.h <- run-auto-test.c dependency dropped. make[4]: Circular run-auto-test.h <- run-auto-test.h dependency dropped. make all-am make[5]: Entering directory `/data/projects/gnome-keyring/egg/tests' make[5]: Circular run-auto-test.h <- run-auto-test.c dependency dropped. make[5]: Circular run-auto-test.h <- run-auto-test.h dependency dropped. /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -g -O2 -Wno-strict-aliasing -Wno-sign-compare -Werror -o run-auto-test run_auto_test-run-auto-test.o run_auto_test-unit-test-asn1.o run_auto_test-unit-test-cleanup.o run_auto_test-unit-test-hex.o run_auto_test-unit-test-oid.o run_auto_test-unit-test-secmem.o run_auto_test-unit-test-symkey.o run_auto_test-unit-test-openssl.o run_auto_test-run-auto-test.o run_auto_test-run-prompt-test.o ../../egg/libegg.la -lgconf-2 -lglib-2.0 -L//lib -ldbus-1 -lpthread -lrt -lgcrypt -ltasn1 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lgio-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lglib-2.0 -pthread -lgthread-2.0 -lrt -lglib-2.0 libtool: link: gcc -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -g -O2 -Wno-strict-aliasing -Wno-sign-compare -Werror -o run-auto-test run_auto_test-run-auto-test.o run_auto_test-unit-test-asn1.o run_auto_test-unit-test-cleanup.o run_auto_test-unit-test-hex.o run_auto_test-unit-test-oid.o run_auto_test-unit-test-secmem.o run_auto_test-unit-test-symkey.o run_auto_test-unit-test-openssl.o run_auto_test-run-auto-test.o run_auto_test-run-prompt-test.o -pthread ../../egg/.libs/libegg.a /usr/lib/libgconf-2.so -L//lib -ldbus-1 -lpthread /lib/libgcrypt.so /usr/lib/libtasn1.so /usr/lib/libgtk-x11-2.0.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libpangoft2-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangocairo-1.0.so /usr/lib/libgio-2.0.so /usr/lib/libcairo.so /usr/lib/libpango-1.0.so /usr/lib/libfreetype.so -lfontconfig /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so /usr/lib/libgthread-2.0.so -lrt /usr/lib/libglib-2.0.so -pthread run_auto_test-run-auto-test.o: In function `test_mainloop_get': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:85: multiple definition of `test_mainloop_get' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:85: first defined here run_auto_test-run-auto-test.o: In function `main': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:160: multiple definition of `main' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:160: first defined here run_auto_test-run-auto-test.o: In function `test_build_filename': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:93: multiple definition of `test_build_filename' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:93: first defined here run_auto_test-run-auto-test.o: In function `test_dir_testdata': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:99: multiple definition of `test_dir_testdata' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:99: first defined here run_auto_test-run-auto-test.o: In function `test_read_testdata': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:122: multiple definition of `test_read_testdata' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:122: first defined here run_auto_test-run-auto-test.o: In function `test_mainloop_run': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:76: multiple definition of `test_mainloop_run' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:76: first defined here run_auto_test-run-auto-test.o: In function `test_mainloop_quit': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:68: multiple definition of `test_mainloop_quit' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:68: first defined here run_auto_test-run-auto-test.o: In function `egg_memory_fallback': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:53: multiple definition of `egg_memory_fallback' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:53: first defined here run_auto_test-run-auto-test.o: In function `egg_memory_unlock': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:47: multiple definition of `egg_memory_unlock' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:47: first defined here run_auto_test-run-auto-test.o: In function `egg_memory_lock': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:42: multiple definition of `egg_memory_lock' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:42: first defined here run_auto_test-run-prompt-test.o: In function `test_mainloop_get': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:85: multiple definition of `test_mainloop_get' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:85: first defined here run_auto_test-run-prompt-test.o: In function `main': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:160: multiple definition of `main' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:160: first defined here run_auto_test-run-prompt-test.o: In function `test_build_filename': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:93: multiple definition of `test_build_filename' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:93: first defined here run_auto_test-run-prompt-test.o: In function `test_dir_testdata': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:99: multiple definition of `test_dir_testdata' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:99: first defined here run_auto_test-run-prompt-test.o: In function `test_read_testdata': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:122: multiple definition of `test_read_testdata' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:122: first defined here run_auto_test-run-prompt-test.o: In function `test_mainloop_run': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:76: multiple definition of `test_mainloop_run' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:76: first defined here run_auto_test-run-prompt-test.o: In function `test_mainloop_quit': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:68: multiple definition of `test_mainloop_quit' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:68: first defined here run_auto_test-run-prompt-test.o: In function `egg_memory_fallback': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:53: multiple definition of `egg_memory_fallback' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:53: first defined here run_auto_test-run-prompt-test.o: In function `egg_memory_unlock': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:47: multiple definition of `egg_memory_unlock' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:47: first defined here run_auto_test-run-prompt-test.o: In function `egg_memory_lock': /data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:42: multiple definition of `egg_memory_lock' run_auto_test-run-auto-test.o:/data/projects/gnome-keyring/egg/tests/../../tests/gtest-helpers.c:42: first defined here collect2: ld returned 1 exit status make[5]: *** [run-auto-test] Error 1 make[5]: Leaving directory `/data/projects/gnome-keyring/egg/tests' make[4]: *** [all] Error 2 make[4]: Leaving directory `/data/projects/gnome-keyring/egg/tests' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/data/projects/gnome-keyring/egg' make[2]: *** [all] Error 2 make[2]: Leaving directory `/data/projects/gnome-keyring/egg' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/data/projects/gnome-keyring' make: *** [all] Error 2
Created attachment 143122 [details] [review] Fixed patch Note to self: even if the code seems identical always run make -j16 on the _whole_ source tree. Thanks for catching it Stef, this patch should fix that build failure as well.
Committed with an additional fix to pkcs11/gck/tests/Makefile.am. Thanks again.