After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576423 - string review
string review
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-23 14:52 UTC by Matthias Clasen
Modified: 2009-03-26 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (52.39 KB, patch)
2009-03-23 14:52 UTC, Matthias Clasen 		committed Details | Review
gdu-gtk patch for the same (5.96 KB, patch)
2009-03-26 04:07 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2009-03-23 14:52:08 UTC 
Here is a patch that changes many of the localized strings. There's a lot of change here, but the bulk of it is

- remove markup from translations

- add context to some short strings that may otherwise be hard to translate or clash

- don't mark "-" for translation (if you really want to, you need to add context, but I don't think it makes sense)

- fix plural handling in one place

- mark some forgotten strings for translation
Comment 1 Matthias Clasen 2009-03-23 14:52:37 UTC 
Created attachment 131189 [details] [review]
patch
Comment 2 Matthias Clasen 2009-03-26 04:07:37 UTC 
Created attachment 131403 [details] [review]
gdu-gtk patch for the same
Comment 3 David Zeuthen (not reading bugmail) 2009-03-26 19:32:02 UTC 
Thanks for the patches. I have committed both of them with the following changes/additions

 - the patches introduced some compiler warnings; I fixed that

 - some of the code had changed so a few hunks didn't apply
   any more.. so I redid the missing parts

 - the patches were incomplete according to looking at the .pot
   file (I also updated POTFILES.in prior to this) after running
   update-po in the po/ directory. I fixed up the remaining strings;
   there are no longer any tags in the strings marked for translation