GNOME Bugzilla – Bug 576347
toolbar label improvements
Last modified: 2009-03-30 15:06:46 UTC
Here is what the HIG says about toolbar labels: - Keep this description as short as possible, preferably a single verb - No trailing ellipsis Here is a patch to improve the palimpsest toolbar in that respect.
Created attachment 131160 [details] [review] patch
Does the HIG really say that? Seems a bit broken to me. FWIW, Evolution says "Reply to all" for one of the toolbar items. Unfortunately the patch breaks the menu items as well. Maybe we should default to "Text besides icons" in the app itself; FWIW, that's my desktop-wide default and it seems a lot nicer. Thoughts?
Yeah, the hig says so. "Reply to All" in evo can be explained by it being right next to the "Reply" button... I don't think I saw the patch break the menus, and I was careful to only change the short labels, which are not used in menus. Defaulting to text besides icons is an interesting point, since the hig also says that - each app that has a toolbar shall have a View -> Show Toolbar check menu item - each app that has a toolbar shall have a way to set the toolbar style, defaulting to the system setting
(In reply to comment #3) > Yeah, the hig says so. "Reply to All" in evo can be explained by it being right > next to the "Reply" button... > > I don't think I saw the patch break the menus, and I was careful to only change > the short labels, which are not used in menus. Maybe it's just PolKitGnomeAction brokenness. > Defaulting to text besides icons is an interesting point, since the hig also > says that > > - each app that has a toolbar shall have a View -> Show Toolbar check menu item > > - each app that has a toolbar shall have a way to set the toolbar style, > defaulting to the system setting > Interesting. We don't have a View menu at all; not sure if we want to add one...
David, I tried the patch again and failed to see any menu breakage. Can you say what exactly you saw break ?
(In reply to comment #5) > David, I tried the patch again and failed to see any menu breakage. Can you say > what exactly you saw break ? Hmm, seems like this works fine now. Committed. Thanks.