GNOME Bugzilla – Bug 576338
video title says "get_video" instead of video name
Last modified: 2009-05-03 01:18:11 UTC
Please describe the problem: when adding a youtube-video to the playlist the resulting entry is named "get_video", not the actual name of the video. Steps to reproduce: 1) Enable Youtube plugin 2) Search for video 3) select a video, right click and add to playlist Actual results: The play list shows 'get_video'. Expected results: The play list should show the name of the video. Does this happen every time? Yes Other information: Reported on Launchpad: http://bugs.launchpad.net/bugs/346661
Created attachment 131149 [details] screenshot of the get_video issue
Created attachment 131150 [details] screenshot 2 of the get_video issue
Created attachment 133564 [details] [review] Display video names for YouTube videos This adds a new TotemObject method: totem_set_current_title, and uses that to override the rubbish title which totem-pl-parser comes up with. Going through totem-pl-parser is unavoidable, since the YouTube plugin uses TotemVideoList.
(In reply to comment #3) > Created an attachment (id=133564) [edit] > Display video names for YouTube videos > > This adds a new TotemObject method: totem_set_current_title, and uses that to > override the rubbish title which totem-pl-parser comes up with. It's not totem-pl-parser which comes up with a title, it's the TotemPlaylist. > Going through > totem-pl-parser is unavoidable, since the YouTube plugin uses TotemVideoList. totem_playlist_add_mrl() has a display_name parameter. Anyway, seems to be fixed in master.
It's the totem_playlist_add_one_mrl in totem_playlist_entry_parsed which is getting called; not the one in totem_playlist_add_mrl. This is because totem-pl-parser is returning SUCCESS for YouTube videos, so they use the rubbish title pl-parser comes up with.
I can't reproduce in master, whether double-clicking, or selecting "add to playlist" from the contextual menu...
What connection speed have you got Totem set to? Perhaps it works for the low-quality videos but not the high-quality ones? It definitely doesn't work for me if searching for "oogle" and playing the video Andreas played in comment #1.
Indeed. But working around totem-pl-parser bugs in totem seems a bit of a round-about way of doing things. Especially when the work-around only ever works if we play the stream straight away. This should fix it: diff --git a/plparse/totem-pl-parser-qt.c b/plparse/totem-pl-parser-qt.c index ef9147e..0037ee3 100644 --- a/plparse/totem-pl-parser-qt.c +++ b/plparse/totem-pl-parser-qt.c @@ -202,14 +202,8 @@ totem_pl_parser_add_quicktime (TotemPlParser *parser, GFile *base_file, gpointer data) { - if (data == NULL || totem_pl_parser_is_quicktime (data, strlen (data)) == NULL) { - char *uri; - - uri = g_file_get_uri (file); - totem_pl_parser_add_one_uri (parser, uri, NULL); - g_free (uri); - return TOTEM_PL_PARSER_RESULT_SUCCESS; - } + if (data == NULL || totem_pl_parser_is_quicktime (data, strlen (data)) == NULL) + return TOTEM_PL_PARSER_UNHANDLED; return totem_pl_parser_add_quicktime_metalink (parser, file, base_file, data); }
Committed a version that works, after testing. commit 520eb5c3f5db1a806fd684a8e7cd9b35b2390fa5 Author: Bastien Nocera <hadess@hadess.net> Date: Sun May 3 02:16:53 2009 +0100 Bug 576338 – video title says "get_video" instead of video name 2009-05-03 Bastien Nocera <hadess@hadess.net> * plparse/totem-pl-parser-qt.c (totem_pl_parser_add_quicktime): Don't implement a fall-back when the top-level parsing code can already do that for us, and we might not want a fall-back. Fixes video/mp4 files played from YouTube showing up with "get_video" as the video name (Closes: #576338)