After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 576289 - tagging PiTiVi's audio streams for pulseaudio
tagging PiTiVi's audio streams for pulseaudio
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal enhancement
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-22 14:04 UTC by Jean-François Fortin Tam
Modified: 2010-01-20 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (622 bytes, patch)
2010-01-15 16:57 UTC, Greg Auger 		none Details | Review
As requested (742 bytes, patch)
2010-01-20 16:00 UTC, Greg Auger 		none Details | Review

Description Jean-François Fortin Tam 2009-03-22 14:04:24 UTC 
http://pulseaudio.org/wiki/ApplicationProperties
I would guess PiTiVi should identify itself as "production"?
Comment 1 Edward Hervey 2009-03-23 07:36:17 UTC 
yes.
Comment 2 Greg Auger 2010-01-15 16:57:31 UTC 
Created attachment 151484 [details] [review]
Patch

I believe this patch fixes the issue (based on the implementation in Jokosher as mentioned in the comments of http://0pointer.de/blog/projects/tagging-audio.html)

Please me gentle, this is my first ever attempt at creating a patch.
Comment 3 Edward Hervey 2010-01-20 12:19:13 UTC 
The patch makes sense. Could you make a newer patch with "git am" or "git show" and attach it here though so that we can commit your patch cleanly ?
Comment 4 Greg Auger 2010-01-20 16:00:38 UTC 
Created attachment 151845 [details] [review]
As requested

I hope this is in the correct format, if not you will have to give me further instructions, sorry.
Comment 5 Edward Hervey 2010-01-20 16:44:32 UTC 
commit 71b62df165564097d6b32cc9140a11a8d6cc8ec3
Author: Greg Auger <gregory.auger@googlemail.com>
Date:   Wed Jan 20 17:46:29 2010 +0100

    Add pulseaudio 'role' tagging
Comment 6 Jean-François Fortin Tam 2010-01-20 21:57:38 UTC 
Nice! I'll update the "pitivi love" wiki page :)