After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575937 - udp/gstudpnetutils.c: ip_mreqn unavailable on Solaris (and others)
udp/gstudpnetutils.c: ip_mreqn unavailable on Solaris (and others)
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other opensolaris
: Normal normal
: 0.10.15
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-19 11:57 UTC by David Adam
Modified: 2009-03-21 03:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build if on Solaris (838 bytes, patch)
2009-03-19 12:01 UTC, David Adam 		committed Details | Review

Description David Adam 2009-03-19 11:57:28 UTC 
gstudpnetutils.c uses the ip_mreqn struct unless building on Windows, where it uses the ip_mreq struct instead; on Solaris, this struct does not exist.

I have a patch to fix this issue on Solaris, but either checking for Linux in the 
'#if' or a configure check might be better as this struct is not available on (Free)BSD either.

Build fails with:
Making all in udp
  CC    gstudpnetutils.o
gstudpnetutils.c: In function `gst_udp_join_group':
gstudpnetutils.c:178: error: storage size of 'mreq4' isn't known
gstudpnetutils.c:178: warning: unused variable `mreq4'
make[4]: *** [libgstudp_la-gstudpnetutils.lo] Error 1

uname: SunOS manduba 5.11 snv_101 sun4u sparc SUNW,Ultra-Enterprise Solaris
Comment 1 David Adam 2009-03-19 12:01:05 UTC 
Created attachment 130955 [details] [review]
Fix build if on Solaris

This patch checks for Solaris and uses ip_mreq instead of ip_mreqn if on this platform. A more robust check could be added using autoconf, or even simply checking for #ifdef __linux__.
Comment 2 Wim Taymans 2009-03-19 12:25:27 UTC 
commit 710ff959e3f640ca4a53bb0d83eaa767db469399
Author: David Adam <zanchey at ucc.gu.uwa.edu.au>
Date:   Thu Mar 19 13:24:02 2009 +0100

    udp: Fix build if on Solaris
    
    This patch checks for Solaris and uses ip_mreq instead of ip_mreqn if on this
    platform.
    Fixes #575937.