After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575854 - UI review: nonsensical step counts
UI review: nonsensical step counts
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: Disks UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-18 16:22 UTC by Matthias Clasen
Modified: 2009-03-30 21:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for the gdu part (1.44 KB, patch)
2009-03-23 00:24 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2009-03-18 16:22:43 UTC 
from http://bugzilla.gnome.org/show_bug.cgi?id=575852

Changing password for LUKS: "(task 1 of 0)"
Comment 1 Matthias Clasen 2009-03-22 14:25:54 UTC 
It seems to me that this should be fixed in DeviceKit-disks, by initializing device->priv->job_num_tasks to 1. 

Also, palimpsest/gdu-section-job.c:job_update should be fixed to suppress the 
(task %d of %d) part if job_num_tasks is < 2.
Comment 2 Matthias Clasen 2009-03-23 00:24:09 UTC 
Created attachment 131147 [details] [review]
patch for the gdu part
Comment 3 David Zeuthen (not reading bugmail) 2009-03-30 21:17:15 UTC 
This applies to more than just LUKS. In fact, it will apply to any job where we run a command not provided by DeviceKit-disks itself. E.g. where the helper doesn't emit progress. For example it also applies to FilesystemMount().

So I think it's probably better to just allow job_num_tasks to be 0 (meaning undefined/unknown).
Comment 4 David Zeuthen (not reading bugmail) 2009-03-30 21:21:37 UTC 
Committed. Thanks.