GNOME Bugzilla – Bug 575710
Dialog messages include unfriendly dbus freedesktop.org strings
Last modified: 2009-03-28 17:19:41 UTC
The dialogs could be made more user-friendly by translating the dbus reponse message better. For example, when trying to format XFS (without xfsprogs installed) it fails as one would expect. The message though reveals a bit too much about the internals: "org.freedesktop.DeviceKit.Disks.Error.Failed: Error creating file system: helper exited with exit code 1: cannot spawn 'mkfs.xfs -L "Fedora Live" /dev/sdb1': Failed to execute child process "mkfs.xfs" (No such file or directory)" Other information:
Created attachment 131479 [details] [review] 0001-don-t-show-dbus-error-names.patch
Created attachment 131480 [details] [review] 0002-add-a-missing-else.patch
Created attachment 131481 [details] [review] 0003-sync-GduError-to-DevkitDisksError.patch
Created attachment 131482 [details] [review] 0004-improve-the-error-dialog.patch
Here is a series of patches that remove the dbus error name from the UI, sync the GduError enum with the DK-d errors, and improves the error dialog by showing a translated string corresponding to error->code and moving error->message to a detail expander. The sync patch has already been attached to another bug.
Applied. Btw, please pay attention to compiler warnings gdu-error.c: In function â_gdu_error_fixupâ: gdu-error.c:58: warning: unused variable âsâ