After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575682 - Add gst_pad_is_compatible()
Add gst_pad_is_compatible()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.23
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-17 12:32 UTC by Zeeshan Ali
Modified: 2009-03-18 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add gst_pad_is_compatible() (2.90 KB, patch)
2009-03-17 12:33 UTC, Zeeshan Ali 		needs-work Details | Review
Patch for vala bindings. (1.54 KB, patch)
2009-03-17 12:55 UTC, Zeeshan Ali 		none Details | Review
Add gst_pad_is_compatible() (2.40 KB, patch)
2009-03-18 13:07 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2009-03-17 12:32:26 UTC 
Attaching a patch that adds the said function to gstutils module.
Comment 1 Zeeshan Ali 2009-03-17 12:33:01 UTC 
Created attachment 130819 [details] [review]
Add gst_pad_is_compatible()
Comment 2 Zeeshan Ali 2009-03-17 12:55:45 UTC 
Created attachment 130821 [details] [review]
Patch for vala bindings.

This is the patch for vala bindings, please change the component to vala (binding) once the previous patch is applied to gstreamer mainline.
Comment 3 Zeeshan Ali 2009-03-17 13:07:27 UTC 
Ok, created a new depended bug on vala for the bindings so just ignore the second patch.
Comment 4 Wim Taymans 2009-03-18 09:34:30 UTC 
Unfortunately gst_pad_can_link() is wrong, it requires that the pads have a parent and it doesn't bother to take any locks whatsoever. 

there is another function that might be better: gst_pad_link_prepare.
Comment 5 Zeeshan Ali 2009-03-18 13:07:58 UTC 
Created attachment 130883 [details] [review]
Add gst_pad_is_compatible()

Modified patch according to last comment by Wim.
Comment 6 Wim Taymans 2009-03-18 16:05:50 UTC 
I reworked it a little. There is no new function but I fixed gst_pad_can_link() instead.

commit 8af9d58ea7daf67f5c752187adea7d6dd00574cf
Author: Zeeshan Ali (Khattak) <zeeshanak at gnome dot org>
Date:   Wed Mar 18 17:01:16 2009 +0100

    gstpad: fix gst_pad_can_link()
    
    Move the gst_pad_can_link() implementation from gstutils to gstpad and use
    gst_pad_link_prepare() to make it work correctly and also check the caps.
    
    Make the broken implementation in gstutils static.
    
    Small cleanups in the _get_fixed_caps() function.
    
    Fixes #575682.