After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575598 - hierarchical pipelines accumulate segment-done wrongly
hierarchical pipelines accumulate segment-done wrongly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-16 20:42 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-03-17 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
segment-done sequence before the change (4.31 KB, text/x-log)
2009-03-16 20:44 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		  Details
segment-done sequence after the change (6.00 KB, text/x-log)
2009-03-16 20:45 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		  Details
send segment-start for first message to parent (1.92 KB, patch)
2009-03-16 20:50 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 20:42:10 UTC 
bin collects segment-start messages and segent-done messages. it posts a segment-done message to its parent, once it has received a segment-done for each segment-start. Imho it should also send a segment-start if it receives the first segment start and if parent is !=NULL. This is needed for bins in bins, so that also higher order bins can group segment-starts and segment-dones. Right now higher order bins will post a segment-done for each segment-done received. Patch follows.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 20:44:44 UTC 
Created attachment 130777 [details]
segment-done sequence before the change
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 20:45:20 UTC 
Created attachment 130778 [details]
segment-done sequence after the change
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 20:50:02 UTC 
Created attachment 130779 [details] [review]
send segment-start for first message to parent
Comment 4 Wim Taymans 2009-03-16 21:13:01 UTC 
Yepp, indeed.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-17 10:08:07 UTC 
commit b3e56e19f53ade895be2c4f21776eebbfceb44ae
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue Mar 17 12:05:33 2009 +0200

bin: forward segment-start like segment-done if parent is also a bin