After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575565 - [mxf] mxf plugin uses symbols not in glib 2.6 (minimum glib version specified by configure.ac)
[mxf] mxf plugin uses symbols not in glib 2.6 (minimum glib version specified...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-16 15:11 UTC by Zaheer Abbas Merali
Modified: 2009-03-18 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix issue (2.55 KB, patch)
2009-03-16 16:36 UTC, Zaheer Abbas Merali 		none Details | Review
with #if and #endif (2.64 KB, patch)
2009-03-16 17:16 UTC, Zaheer Abbas Merali 		committed Details | Review
Newer patch (8.98 KB, patch)
2009-03-18 10:39 UTC, Jan Schmidt 		none Details | Review

Description Zaheer Abbas Merali 2009-03-16 15:11:05 UTC 
g_hash_table_get_values is only in 2.14 and is used in #else parts of #if GLIB_CHECK_VERSION(2, 16, 0)

Patch coming
Comment 1 Zaheer Abbas Merali 2009-03-16 16:35:39 UTC 
I meant 2.6!

configure.ac in gst-plugins-bad says 2.6 is minimum glib version in gst-plugins-bad.
Comment 2 Zaheer Abbas Merali 2009-03-16 16:36:40 UTC 
Created attachment 130760 [details] [review]
patch to fix issue
Comment 3 Sebastian Dröge (slomo) 2009-03-16 16:58:22 UTC 
Looks good but you should put the list-append functions inside a #if/#endif block. Otherwise gcc will complain about unused static functions.

Let's hope we depend on glib 2.16 soon ;)
Comment 4 Zaheer Abbas Merali 2009-03-16 17:16:33 UTC 
Created attachment 130766 [details] [review]
with #if and #endif
Comment 5 Jan Schmidt 2009-03-18 10:39:42 UTC 
Created attachment 130873 [details] [review]
Newer patch

The previous patch has some build warnings, fixed with this one.
Comment 6 Jan Schmidt 2009-03-18 12:22:11 UTC 
Committed after review from Edward:

commit cf4485133b741355d97abf4bf784b7af91f9aaba
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Wed Mar 18 10:35:43 2009 +0000

    mxfdemux: Fix build on GLib < 2.16 some more