After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575393 - Crash in excel chart import code
Crash in excel chart import code
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
git master
Other All
: Normal critical
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-03-14 22:31 UTC by sum1
Modified: 2009-03-15 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xls file (601.50 KB, application/vnd.ms-excel)
2009-03-14 22:32 UTC, sum1
  Details
Tentative patch (513 bytes, patch)
2009-03-14 23:27 UTC, Morten Welinder
none Details | Review

Description sum1 2009-03-14 22:31:17 UTC
Version: r17202
OS: Ubuntu Intrepid

The upcoming .xls attachment was created by converting Attachment 80523 [details] (a .gnumeric file from Bug 397679) with ssconvert.

Steps to reproduce:
- Import the upcoming .xls attachment


Backtrace:

WARNING **: value_release problem.
CRITICAL **: value_release: assertion `value != NULL' failed
CRITICAL **: value_release: assertion `value != NULL' failed

Program received signal SIGSEGV, Segmentation fault.

Thread 3067598592 (LWP 23883)

  • #0 value_release
    at value.c line 535
  • #1 ms_excel_chart_read_NUMBER
    at ms-chart.c line 3416
  • #2 ms_excel_chart_read
    at ms-chart.c line 3578
  • #3 ms_excel_chart_read_BOF
    at ms-chart.c line 3773
  • #4 ms_read_OBJ
    at ms-obj.c line 1279
  • #5 ms_escher_read_ClientData
    at ms-escher.c line 1993
  • #6 ms_escher_read_container
    at ms-escher.c line 2099
  • #7 ms_escher_read_SpContainer
    at ms-escher.c line 507
  • #8 ms_escher_read_container
    at ms-escher.c line 2099
  • #9 ms_escher_read_SpgrContainer
    at ms-escher.c line 1933
  • #10 ms_escher_read_container
    at ms-escher.c line 2099
  • #11 ms_escher_read_DgContainer
    at ms-escher.c line 1938
  • #12 ms_escher_read_container
    at ms-escher.c line 2099
  • #13 ms_escher_parse
    at ms-escher.c line 2166
  • #14 excel_read_sheet
    at ms-excel-read.c line 6250
  • #15 excel_read_BOF
    at ms-excel-read.c line 6533
  • #16 excel_read_workbook
    at ms-excel-read.c line 6616
  • #17 excel_file_open
    at boot.c line 192
  • #18 go_plugin_loader_module_func_file_open
    at go-plugin-loader-module.c line 239
  • #19 go_plugin_file_opener_open
    at go-plugin-service.c line 476
  • #20 go_file_opener_open
    at file.c line 299
  • #21 wb_view_new_from_input
    at workbook-view.c line 1057
  • #22 wb_view_new_from_uri
    at workbook-view.c line 1111
  • #23 main
    at main-application.c line 445

Comment 1 sum1 2009-03-14 22:32:33 UTC
Created attachment 130682 [details]
xls file
Comment 2 Morten Welinder 2009-03-14 23:27:47 UTC
Created attachment 130683 [details] [review]
Tentative patch

This might work.  No-one was checking "row" for sanity.
Comment 3 Jean Bréfort 2009-03-15 10:16:25 UTC
Looks good, but should be applied to ms_excel_chart_read_LABEL as well.
Comment 4 Morten Welinder 2009-03-15 18:14:53 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.