After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575295 - Question-button label mismatch in the closing dialog
Question-button label mismatch in the closing dialog
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-13 22:11 UTC by Simon van der Linden
Modified: 2009-06-24 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prints "Close this wIndow?" only if more than one tab would be closed (678 bytes, patch)
2009-03-13 22:39 UTC, Simon van der Linden 		accepted-commit_now Details | Review

Description Simon van der Linden 2009-03-13 22:11:03 UTC 
In the "Close this window?" dialog, the label of the button is "Close Terminal" if there is only one terminal. When there are more than one, the label of the button becomes "Close Window", while the question remains the same.

I think the label of the button should corresponds to the question in both cases:
Close this window? => Close Window
Close this terminal? => Close Terminal
Comment 1 Simon van der Linden 2009-03-13 22:39:04 UTC 
Created attachment 130611 [details] [review]
Prints "Close this wIndow?" only if more than one tab would be closed
Comment 2 Christian Persch 2009-03-30 17:00:59 UTC 
I don't see the problem here...

screen != NULL iff we're closing just one tab (tab close button, or File->Close tab), while it's == NULL if we're closing the whole window. So it would seem to me that the button labels are correct as they are now...
Comment 3 Christian Persch 2009-05-27 12:38:14 UTC 
Ok, I see the problem. Patch is fine, please commit to master.