After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575284 - add auto-connect-forced mode to jackaudiosrc and jackaudiosink
add auto-connect-forced mode to jackaudiosrc and jackaudiosink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 0.10.12
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-13 19:30 UTC by Tristan Matthews
Modified: 2009-03-20 13:22 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
provides described functionality (3.31 KB, patch)
2009-03-13 19:33 UTC, Tristan Matthews 		none Details | Review
patch that provides the new connect mode (3.31 KB, patch)
2009-03-13 19:45 UTC, Tristan Matthews 		committed Details | Review

Description Tristan Matthews 2009-03-13 19:30:05 UTC 
Currently, the gst-jack auto-connect mode will limit the number of ports created to the number of available physical ports. It would be good to have another option that would create as many ports as are requested via caps, and only connect as many as there are phyiscal ports.
Comment 1 Tristan Matthews 2009-03-13 19:33:13 UTC 
Created attachment 130599 [details] [review]
provides described functionality

This adds the mode "auto-connect-forced" to the avaiable modes of the connect property for both jackaudiosrc and jackaudiosink. it also gets rid of an unwanted g_print line in jackaudiosrc.
Comment 2 Tristan Matthews 2009-03-13 19:45:02 UTC 
Created attachment 130600 [details] [review]
patch that provides the new connect mode
Comment 3 Wim Taymans 2009-03-16 18:26:33 UTC 
Will commit after the freeze/release.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 19:34:19 UTC 
Tristan, you could turn the g_print into a G_DEBUG_OBJECT(). Besides I wonder how the mod is going to be implemented. Will you do a patch for this as well?
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2009-03-16 19:36:08 UTC 
Forget my second comment. It was not clean from them context diff what the patch actually does. Sorry for the noise.
Comment 6 Wim Taymans 2009-03-20 13:22:24 UTC 
will push after freeze.

commit afd3788f3c9438aa078bd93edd220968dfdddb29
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 16 11:21:02 2009 +0100

    jack: Add new connection mode
    
    Add a new connection mode to jacksrc and jacksink. In this new auto-force
    connection mode jack will create as many ports as requested/needed in the
    pipeline and will then connect as many physical ports as possible, possibly
    leaving some ports unconnected.
    
    Also get rid of some leftover g_print.
    
    Fixes #575284.