After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574865 - gnome-display-properties crashed with SIGSEGV in strcmp()
gnome-display-properties crashed with SIGSEGV in strcmp()
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
2.25.x
Other Linux
: Immediate blocker
: ---
Assigned To: Soren Sandmann Pedersen
Control-Center Maintainers
Depends on:
Blocks: randr-tracker
 
 
Reported: 2009-03-10 23:15 UTC by Sebastien Bacher
Modified: 2009-03-11 15:17 UTC
See Also:
GNOME target: 2.26.x
GNOME version: 2.25/2.26


Attachments
gnome-control-center-bgo574865-current-output-dangling-pointer.diff (2.08 KB, patch)
2009-03-11 00:51 UTC, Federico Mena Quintero
none Details | Review

Description Sebastien Bacher 2009-03-10 23:15:28 UTC
the bug has been opened on https://bugs.launchpad.net/bugs/340386

"I switched the screen, the confirm dialog appeared and at the same time gnome-display-properties crashed.

gnome-control-center 1:2.25.92-0ubuntu3

  • #0 strcmp
    at ../sysdeps/x86_64/strcmp.S line 30
  • #1 gnome_rr_screen_get_output_by_name
    at gnome-rr.c line 911
  • #2 get_current_modes
    at xrandr-capplet.c line 367
  • #3 rebuild_rate_combo
    at xrandr-capplet.c line 484
  • #4 rebuild_gui
    at xrandr-capplet.c line 686
  • #5 select_current_output_from_dialog_position
    at xrandr-capplet.c line 2139
  • #6 screen_update
    at gnome-rr.c line 494
  • #7 screen_on_event
    at gnome-rr.c line 520
  • #8 gdk_event_translate
    at /build/buildd/gtk+2.0-2.15.5/gdk/x11/gdkevents-x11.c line 349
  • #9 _gdk_events_queue
    at /build/buildd/gtk+2.0-2.15.5/gdk/x11/gdkevents-x11.c line 2298
  • #10 gdk_event_dispatch
    at /build/buildd/gtk+2.0-2.15.5/gdk/x11/gdkevents-x11.c line 2358
  • #11 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.19.10/glib/gmain.c line 1814
  • #12 g_main_context_iterate
    at /build/buildd/glib2.0-2.19.10/glib/gmain.c line 2448
  • #13 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.19.10/glib/gmain.c line 2656
  • #14 IA__gtk_dialog_run
    at /build/buildd/gtk+2.0-2.15.5/gtk/gtkdialog.c line 1090
  • #15 main
    at xrandr-capplet.c line 2304

Comment 1 Federico Mena Quintero 2009-03-11 00:51:26 UTC
Created attachment 130442 [details] [review]
gnome-control-center-bgo574865-current-output-dangling-pointer.diff

Oops.  We were leaving a dangling pointer in app->current_output.  This is pending approval from the release team.
Comment 2 Federico Mena Quintero 2009-03-11 01:06:13 UTC
This bug is also https://bugzilla.novell.com/show_bug.cgi?id=457772
Comment 3 Federico Mena Quintero 2009-03-11 15:17:33 UTC
Committed to trunk (r9339).

2009-03-11  Federico Mena Quintero  <federico@novell.com>

	http://bugzilla.gnome.org/show_bug.cgi?id=574865 - Crash when
	refreshing the RANDR configuration.

	* xrandr-capplet.c (select_current_output_from_dialog_position):
	Always set app->current_output; otherwise we could be left with a
	dangling pointer to the old current_output (which is invalid after
	refreshing the current_configuration).
	(on_screen_changed): Null out the current_output when we get a new
	RANDR configuration, as it will become obsolete as soon as we free
	the old configuration.