After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574746 - Disable external library decoders/encoders
Disable external library decoders/encoders
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-10 11:30 UTC by Christian Fredrik Kalager Schaller
Modified: 2009-03-10 20:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Disable usage of external library encoders. (855 bytes, patch)
2009-03-10 12:10 UTC, Edward Hervey
committed Details | Review

Description Christian Fredrik Kalager Schaller 2009-03-10 11:30:31 UTC
The ffmpeg h264 encoder plugin is broken and should be disabled. It causes applications like Empathy which tries to dynamically plug it to crash. The x264 encoder works fine, so there is no need to have a broken ffmpeg plugin enabled.
Comment 1 Christian Fredrik Kalager Schaller 2009-03-10 11:32:56 UTC
To make sure, the plugin which should not be built is:
ffenc_libx264
Comment 2 Edward Hervey 2009-03-10 11:42:41 UTC
*sigh*... this is from an unsupported build.

I don't know whether I should:
* close the bug, or
* really disable libx264 plugin in gst-ffmpeg (even though we don't support it).
Comment 3 Edward Hervey 2009-03-10 12:10:01 UTC
Created attachment 130396 [details] [review]
Disable usage of external library encoders.

So basically we have native gstreamer plugins for all the external libraries they use. Just blacklist them.
Comment 4 Tim-Philipp Müller 2009-03-10 12:47:27 UTC
+1 from me for this patch.
Comment 5 Olivier Crête 2009-03-10 14:46:49 UTC
Yea, I'm not sure the implementation is great, but with the ffmpeg release.. We want to use system ffmpeg so we really need something like that.
Comment 6 Edward Hervey 2009-03-10 20:14:09 UTC
commit 1e689f057ff8969ae6cda8093d5a92a5490dedaa
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Tue Mar 10 21:11:43 2009 +0100

    Disable exposing decoder/encoder using external library. Fixes #574746