GNOME Bugzilla – Bug 574623
[dot_file_with_ts] ':' not a valid character for a filename
Last modified: 2009-03-09 14:04:12 UTC
Hi, -- steps to reproduce: set GST_DEBUG_DUMP_DOT_DIR=. set GST_DEBUG=2 gst-launch-0.10 fakesrc num_buffers=10 ! fakesink -- result: gst\gstdebugutils.c:571:_gst_debug_bin_to_dot_file:←[00m Failed to open file 'c:\0:00:00.170245000-gst-launch.NULL_READY.dot' for writing: Invalid argument -- infos: it fails on: fopen (full_file_name, "wb") On windows, a file name cannot contains any of the following charaters: \ / : * ? " < > | And in the timestamp there is: ':' g_strdup_printf ("%" GST_TIME_FORMAT "-%s", GST_TIME_ARGS (elapsed), file_name); and #define GST_TIME_FORMAT "u:%02u:%02u.%09u" -- other: I can make a patch that just replace the 2 characters ':' by a '_' but I would like to know what do you think about it first.
Right thats the timestamp. Too bad that glib has nothing there. Let me just fix it. Thanks for analysing it.
commit 50fdaa4f25c32c3971b5d0a559913c5138ac7e0e Author: Stefan Kost <ensonic@users.sf.net> Date: Mon Mar 9 16:01:20 2009 +0200 dump2dot: don't use GST_TIME_FORMAT when building filenames. fixes #574623