After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574530 - gtkmm-documentation: html should not rebuild when building the tarball.
gtkmm-documentation: html should not rebuild when building the tarball.
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2009-03-08 09:37 UTC by Deng Xiyue
Modified: 2009-09-17 05:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtkmm-doc_xsltproc.patch (1.69 KB, patch)
2009-03-08 09:38 UTC, Deng Xiyue
none Details | Review
distcheck.log.gz (66.54 KB, application/x-gzip)
2009-04-01 15:26 UTC, Deng Xiyue
  Details

Description Deng Xiyue 2009-03-08 09:37:52 UTC
Currently it is not easy to pass --nonet to xsltproc when building gtkmm-documentation.  The proposed patch makes XSLTPROC check for envvar as done by DOCBOOK_STYLESHEET, so that one can control its behavior through envvar as well.  The --nonet is intend to help with easier building when network connection is not feasible, such as auto build daemon in Debian.
Comment 1 Deng Xiyue 2009-03-08 09:38:50 UTC
Created attachment 130267 [details] [review]
gtkmm-doc_xsltproc.patch
Comment 2 Murray Cumming 2009-03-09 11:48:33 UTC
But surely this should not be necessary when building from a tarball? All the HTML should be in the tarball already.
Comment 3 Deng Xiyue 2009-03-09 14:00:10 UTC
Indeed.  Then there must be something wrong with gtkmm-documentation 2.14.0, which builds the tutorial anyway though htmls are already generated, and I haven't figured out why yet.
Comment 4 Murray Cumming 2009-03-09 17:17:44 UTC
I can confirm this.
Comment 5 Murray Cumming 2009-03-09 17:25:33 UTC
I think this is caused because somehow C/gtkmm-tut-with-examples.xml is newer than html/index.html in the tarball:

murrayc@murrayc-desktop:~/svn/gnome220/gtkmm-documentation/gtkmm-documentation-2.14.2/docs/tutorial$ ls -lah C/gtkmm-tut-with-examples.xml 
-rw-r--r-- 1 murrayc murrayc 581K 2009-03-09 17:52 C/gtkmm-tut-with-examples.xml
murrayc@murrayc-desktop:~/svn/gnome220/gtkmm-documentation/gtkmm-documentation-2.14.2/docs/tutorial$ ls -lah html/index.html 
-rw-r--r-- 1 murrayc murrayc 26K 2009-03-09 17:46 html/index.html


Though that is not true in the svn checkout where I ran distcheck:

murrayc@murrayc-desktop:~/svn/gnome220/gtkmm-documentation/docs/tutorial$ ls -lah C/gtkmm-tut-with-examples.xml 
-rw-r--r-- 1 murrayc murrayc 581K 2009-03-09 17:46 C/gtkmm-tut-with-examples.xml
murrayc@murrayc-desktop:~/svn/gnome220/gtkmm-documentation/docs/tutorial$ ls -lah html/index.html 
-rw-r--r-- 1 murrayc murrayc 26K 2009-03-09 17:46 html/index.html


Maybe something is causing gtkmm-tut-with-examples.xml to be regenerated during distcheck.
Comment 6 Murray Cumming 2009-03-09 17:26:21 UTC
Of course, it would be nice if the timestamps were irrelevant when not using maintainer mode, so it would not try to rebuild these files even if some files were newer.
Comment 7 Deng Xiyue 2009-04-01 15:26:11 UTC
Created attachment 131847 [details]
distcheck.log.gz

Attaching a local distcheck log. There is a possibility that C/gtkmm-tut-with-examples.xml is copied later than html/index.html and hence end up with a newer timestamp, though I don't quite get the full idea of a distcheck and on which stage the tarball is actually created.
Comment 8 Murray Cumming 2009-09-15 13:23:49 UTC
I guess this is fixed now, Daniel?
Comment 9 Daniel Elstner 2009-09-16 22:35:25 UTC
It wasn't fixed, but it is now. Turns out the doc-dist-hook rule of gnome-doc-utils.make invokes $(INSTALL_DATA) to copy the files into the distribution, which is inappropriate outside of an install rule. As a result, the files copied into the tarball had their timestamps updated, which then triggered the rebuild.

I completely got rid of the dist-hook now and use plain Automake functionality to distribute these files, which works nicely. Nonetheless, gnome-doc-utils.make should still be fixed after the freeze.
Comment 10 Murray Cumming 2009-09-17 05:32:07 UTC
Thanks. So did you file a bug for gnome-doc-utils?