After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574528 - Make gnome-format HIG compatible
Make gnome-format HIG compatible
Status: RESOLVED WONTFIX
Product: gnome-format
Classification: Deprecated
Component: general
SVN
Other Linux
: Normal normal
: ---
Assigned To: gnome-format-maint
gnome-format-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2009-03-08 09:02 UTC by Felix Kaser
Modified: 2012-03-07 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Gnome format UI (20.00 KB, application/x-compressed-tar)
2009-04-06 09:59 UTC, martellc
Details

Description Felix Kaser 2009-03-08 09:02:46 UTC
I don't think that the gnome-format gui is HIG compatible at the moment. We should definitely look at this.

The way the buttons are organized seems weird....
Comment 1 martellc 2009-04-06 09:59:01 UTC
Created attachment 132176 [details]
Gnome format UI

Hi, I make some small changes to the gnome-format ui to made it more HIG compatible (I don't guarentee on the result) :) .

List of changes in the confirmation alert box:
I introduced a primary text "Are you sure you want to format the selected device?".

List of changes in the main window:
- I introduced a menubar: I actually don't like it but an access point for the about window was needed and I think it should be a menu item instead of a button in the bottom of the main window.
- I made some changes to the progress bar: First the progress bar has to be hidden until the formatting process start. I think that the progress bar must have an indicator of the time left and the device being formatted.
- I collapsed all the information about a volume (volume selection,name,fs-type) in a "Volume Settings" Frame. I'm wondering if something like "Format Settings" could be better.
The button box in the bottom side of the window present only 3 button: "Close", "Format" and "Advanced...".

Hope this could be useful.
Christian
Comment 2 Felix Kaser 2009-04-06 10:23:09 UTC
thanks a lot christian....

but again: a patch file would be much more help :) even if you only change one file...please send a svn diff file! That makes the changes good visible and applicable on other working copies!

As far as I know, we don't make gnome-format.ui out of gnome-format.glade! Since both files are in svn, please generate the .ui file witch everey .glade file you change! they should be synchronous! The way we do it is not so good, but there are problems (at least have been, we've to check the new glade...) using glade files with gtk-builder!

To convert glade files into ui files you can use "gtk-builder-convert gnome-format.glade gnome-format.ui"


cheers
felix
Comment 3 Michael Kanis 2009-04-06 12:27:38 UTC
As of version 3.6.0 Glade apparently can write proper GtkBuilder files that don't crash GtkBuilder. Please only update the .ui file in the future, I'll delete the .glade file now.
Comment 4 Felix Kaser 2009-04-07 14:02:57 UTC
This brings up the problem that the new version of glade requires gtk+ 2.16, which not everybody has yet! Gnome 2.24 was shipped with 2.14 I think...

We need to increase the dependcy of gtk+...at the moment it's 2.10.something! Michael can you do that and test it? You seem to have gtk+ 2.16, I don't have it so it makes it impossible to test. We should ship the glade file for some time too... it would give me the possibility to build my own .ui file which is gtk+ 2.14 compatible!
Comment 5 Michael Kanis 2009-04-16 12:56:21 UTC
I think it wouldn't be good to update as long as you still have GTK+ 2.14.
AFAIK GTK+ 2.16 will be included in Ubuntu 9.04, which is coming out soon. Felix, would it be OK for you to update to 2.16 then?
Till then, we'll stick with the manual glade -> ui file conversion.
Comment 6 Felix Kaser 2009-04-16 14:39:43 UTC
copy that :)
Comment 7 André Klapper 2012-03-07 21:11:26 UTC
According to its developers, gnome-format is not under active development
anymore and has ben superseded by gnome-disk-utility.

There will not be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping - Please feel
free to reopen this bug report in the future if anyone takes the responsibility
for active development again.