Bug 574397 – Crashed after Gabble crashed when trying to call a contact

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 574397 - Crashed after Gabble crashed when trying to call a contact


Summary:	Crashed after Gabble crashed when trying to call a contact


Status:	RESOLVED NOTGNOME

Product:	empathy
Classification:	Core
Component:	VoIP
Version:	2.25.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-03-06 17:09 UTC by Guillaume Desmottes
Modified:	2009-03-20 13:34 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Guillaume Desmottes 2009-03-06 17:09:33 UTC

I tried to call my N810. For some reason Gabble crashed and Empathy followed.

(empathy:14883): tp-glib-DEBUG: _tp_connection_clean_up_handle_refs: 0x8c2e508
** (empathy:14883): DEBUG: tp_contact_factory_connection_invalidated_cb: Connection invalidated
(empathy:14883): tp-glib-DEBUG: tp_connection_dispose: 0x8c2e508
(empathy:14883): tp-glib-DEBUG: tp_proxy_dispose: 0x8c2e508
(empathy:14883): tp-glib-DEBUG: tp_connection_finalize: 0x8c2e508
(empathy:14883): tp-glib-DEBUG: tp_proxy_finalize: 0x8c2e508
** (empathy:14883): DEBUG: tp_call_request_streams_cb: Error requesting streams: Name owner lost (service crashed?)

** (empathy:14883): WARNING **: ListProperties(): Name owner lost (service crashed?)

Program received signal SIGSEGV, Segmentation fault.

+ Trace 213225

Thread 3062163232 (LWP 14883)

#0 get_session_handlers_reply
at channel.c line 865
#1 _tp_cli_channel_interface_media_signalling_invoke_callback_get_session_handlers
at _gen/tp-cli-channel-body.h line 7193
#2 tp_proxy_pending_call_idle_invoke
at proxy-methods.c line 153
#3 g_idle_dispatch
at /build/buildd/glib2.0-2.18.2/glib/gmain.c line 4235
#4 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.18.2/glib/gmain.c line 2144
#5 g_main_context_iterate
at /build/buildd/glib2.0-2.18.2/glib/gmain.c line 2778
#6 IA__g_main_loop_run
at /build/buildd/glib2.0-2.18.2/glib/gmain.c line 2986
#7 IA__gtk_main
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkmain.c line 1200
#8 main
at empathy.c line 564

Comment 1 Simon McVittie 2009-03-20 13:10:21 UTC

> get_session_handlers_reply (channel_proxy=0x8ff8f10, session_handlers=0x0,
> error=0x8ed7100, user_data=0x0, weak_object=0x8fe1c08) at channel.c:865
> 865       self->priv->sessions = g_ptr_array_sized_new (session_handlers->len);
> (gdb) bt
> #0  get_session_handlers_reply (channel_proxy=0x8ff8f10, session_handlers=0x0,
> error=0x8ed7100, user_data=0x0, weak_object=0x8fe1c08) at channel.c:865

It is incorrect for get_session_handlers_reply() to dereference @session_handlers without first checking whether @error is NULL. If @error is non-NULL then the call failed and the return values are meaningless.

I *think* this particular channel.c is part of telepathy-farsight - what version do you have installed?

Comment 2 Guillaume Desmottes 2009-03-20 13:34:08 UTC

That's actually a telepathy-farsight bug:
http://bugs.freedesktop.org/show_bug.cgi?id=20765