After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574326 - flags bool() as method too
flags bool() as method too
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Glib
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2009-03-05 23:41 UTC by Kevin Ryde
Modified: 2009-07-19 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
change to have $flags->bool as a method, as well as an overload (3.12 KB, patch)
2009-03-05 23:44 UTC, Kevin Ryde
committed Details | Review

Description Kevin Ryde 2009-03-05 23:41:41 UTC
I got to the change below for having $flags->bool available as a method as well as an overload.  It changes the parameters names to "f" for flags instead of "a" from a,b,swap, and in the to_arrayref bit as well, for the benefit of the generated docs and usage message.

I think the binary ops may be best left alone for now.  If they were methods you'd probably like them to take any number of args, instead of just 1.  But doing that could make the swap arg ambiguous, so leave those bits alone for now.
Comment 1 Kevin Ryde 2009-03-05 23:44:32 UTC
Created attachment 130163 [details] [review]
change to have $flags->bool as a method, as well as an overload
Comment 2 Torsten Schoenfeld 2009-07-19 14:37:58 UTC
Committed with minor modifications: <http://git.gnome.org/cgit/perl-Glib/commit/?id=f61bde5>.  Thanks!