After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574305 - Gtk2::TreeModelFilter::new() reference leak
Gtk2::TreeModelFilter::new() reference leak
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2009-03-05 20:52 UTC by Kevin Ryde
Modified: 2009-03-08 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
diff and test case (2.23 KB, patch)
2009-03-05 20:57 UTC, Kevin Ryde 		none Details | Review

Description Kevin Ryde 2009-03-05 20:52:03 UTC 
When a Gtk2::TreeModelFilter is created by Gtk2::TreeModelFilter::new() I believe it's not destroyed when no longer referenced from perl.  Failing .t case in the diff below.

I think it's just a case of wanting "_noinc" on the return, since gtk_tree_model_filter_new() is a constructor and returns a ref_count of 1 ready to take over.  Change in the diff below seems to work for me.
Comment 1 Kevin Ryde 2009-03-05 20:57:44 UTC 
Created attachment 130153 [details] [review]
diff and test case
Comment 2 Torsten Schoenfeld 2009-03-08 18:01:18 UTC 
Committed.  Thanks!