After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 574288 - [dshowvideosink] mingw compile patch
[dshowvideosink] mingw compile patch
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-03-05 17:36 UTC by Thomas Löwe
Modified: 2011-08-19 23:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Löwe 2009-03-05 17:36:11 UTC 
dshowvideosink doesn't compile under mingw. the following patch fixed this for me:

--- dshowvideosink.cpp.org	2009-03-02 22:30:31.000000000 +0100
+++ dshowvideosink.cpp	2009-03-04 20:58:16.000000000 +0100
@@ -1602,8 +1602,8 @@
 }
 
 /* Plugin entry point */
-extern "C" static gboolean
-plugin_init (GstPlugin * plugin)
+extern "C" {
+static gboolean plugin_init (GstPlugin * plugin)
 {
   /* PRIMARY: this is the best videosink to use on windows */
   if (!gst_element_register (plugin, "dshowvideosink",
@@ -1612,9 +1612,12 @@
 
   return TRUE;
 }
+}
 
-extern "C" GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,
+extern "C" {
+GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,
     GST_VERSION_MINOR,
     "dshowsinkwrapper",
     "DirectShow sink wrapper plugin",
     plugin_init, VERSION, "LGPL", GST_PACKAGE_NAME, GST_PACKAGE_ORIGIN)
+}
Comment 1 Tim-Philipp Müller 2010-08-08 15:35:26 UTC 
Is this still a problem?

I think generally things compile fine with mingw these days.
Comment 2 Tim-Philipp Müller 2010-08-08 15:37:49 UTC 
This was meant to be set to NEEDINFO, not FIXED.
Comment 3 Thomas Löwe 2010-08-10 12:56:28 UTC 
Get a "dshowvideosink.cpp:1613: Error: invalid use of »static« in linkage specification" here using Ubuntu 10.4 with mingw32.
Comment 4 Tim-Philipp Müller 2010-08-10 13:17:41 UTC 
> Get a "dshowvideosink.cpp:1613: Error: invalid use of »static« in linkage
> specification" here using Ubuntu 10.4 with mingw32.

Could you try the git version please? (or the upcoming pre-release) There've been quite a few changes lately.
Comment 5 Thomas Löwe 2010-08-10 15:18:17 UTC 
I've tried this some days ago and give up after some hours (mixing mingw and microsoft headers) - can't get it to compile here, sorry.
Comment 6 Tobias Mueller 2010-09-27 10:38:32 UTC 
Reopening as the requested information has been provided.
Comment 7 Sebastian Dröge (slomo) 2011-05-20 05:37:49 UTC 
What are the exact compiler errors you get with latest GIT? Does it work now?
Comment 8 Akhil Laddha 2011-07-04 05:19:57 UTC 
Thomas, does git source (master) compile for you ?
Comment 9 Fabio Durán Verdugo 2011-08-19 23:37:15 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!